From: John Hubbard <jhubbard@nvidia.com>
To: Qiujun Huang <hqjagain@gmail.com>, <akpm@linux-foundation.org>
Cc: <ira.weiny@intel.com>, <jgg@ziepe.ca>, <dan.j.williams@intel.com>,
<rppt@linux.ibm.com>, <aneesh.kumar@linux.ibm.com>,
<keith.busch@intel.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm:fix gup_pud_range
Date: Fri, 20 Sep 2019 12:37:04 -0700 [thread overview]
Message-ID: <1a162778-41b9-4428-1058-82aaf82314b1@nvidia.com> (raw)
In-Reply-To: <1568994684-1425-1-git-send-email-hqjagain@gmail.com>
On 9/20/19 8:51 AM, Qiujun Huang wrote:
> __get_user_pages_fast try to walk the page table but the
> hugepage pte is replace by hwpoison swap entry by mca path.
I expect you mean MCE (machine check exception), rather than mca?
> ...
> [15798.177437] mce: Uncorrected hardware memory error in
> user-access at 224f1761c0
> [15798.180171] MCE 0x224f176: Killing pal_main:6784 due to
> hardware memory corruption
> [15798.180176] MCE 0x224f176: Killing qemu-system-x86:167336
> due to hardware memory corruption
> ...
> [15798.180206] BUG: unable to handle kernel
> [15798.180226] paging request at ffff891200003000
> [15798.180236] IP: [<ffffffff8106edae>] gup_pud_range+
> 0x13e/0x1e0
> ...
>
> We need to skip the hwpoison entry in gup_pud_range.
It would be nice if this spelled out a little more clearly what's
wrong. I think you and Aneesh are saying that the entry is really
a swap entry, created by the MCE response to a bad page?
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> mm/gup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 98f13ab..6157ed9 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -2230,6 +2230,8 @@ static int gup_pud_range(p4d_t p4d, unsigned long addr, unsigned long end,
> next = pud_addr_end(addr, end);
> if (pud_none(pud))
> return 0;
> + if (unlikely(!pud_present(pud)))
> + return 0;
If the MCE hwpoison behavior puts in swap entries, then it seems like all
page table walkers would need to check for p*d_present(), and maybe at all
levels too, right?
thanks,
--
John Hubbard
NVIDIA
> if (unlikely(pud_huge(pud))) {
> if (!gup_huge_pud(pud, pudp, addr, next, flags,
> pages, nr))
>
next prev parent reply other threads:[~2019-09-20 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 15:51 [PATCH 3/3] mm:fix gup_pud_range Qiujun Huang
2019-09-20 15:58 ` Aneesh Kumar K.V
2019-09-20 19:37 ` John Hubbard [this message]
2019-09-21 0:33 ` Qiujun Huang
[not found] ` <ce863f5b-2337-1ac3-4d3d-d1d62acbba24@nvidia.com>
2019-09-21 1:47 ` Qiujun Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a162778-41b9-4428-1058-82aaf82314b1@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=hqjagain@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).