From: Sinan Kaya <okaya@codeaurora.org>
To: Robin Murphy <robin.murphy@arm.com>,
amd-gfx@lists.freedesktop.org, timur@codeaurora.org,
sulrich@codeaurora.org
Cc: "Tom St Denis" <tom.stdenis@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Emily Deng" <Emily.Deng@amd.com>,
"David Airlie" <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"David Panariti" <David.Panariti@amd.com>,
"Jim Qu" <Jim.Qu@amd.com>, "Huang Rui" <ray.huang@amd.com>,
"Roger He" <Hongbo.He@amd.com>, "Monk Liu" <Monk.Liu@amd.com>,
"Feifei Xu" <Feifei.Xu@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, hch@lst.de
Subject: Re: [PATCH V2] drm/amdgpu: limit DMA size to PAGE_SIZE for scatter-gather buffers
Date: Wed, 11 Apr 2018 10:33:14 -0400 [thread overview]
Message-ID: <1a1d0069-c8d3-cc0d-cf1c-8e90e4a2b0d7@codeaurora.org> (raw)
In-Reply-To: <32b82296-bba5-b5f1-266b-45c1ed66da94@arm.com>
On 4/11/2018 8:03 AM, Robin Murphy wrote:
> On 10/04/18 21:59, Sinan Kaya wrote:
>> Code is expecing to observe the same number of buffers returned from
>> dma_map_sg() function compared to sg_alloc_table_from_pages(). This
>> doesn't hold true universally especially for systems with IOMMU.
>
> So why not fix said code? It's clearly not a real hardware limitation, and the map_sg() APIs have potentially returned fewer than nents since forever, so there's really no excuse.
Sure, I'll take a better fix if there is one.
>
>> IOMMU driver tries to combine buffers into a single DMA address as much
>> as it can. The right thing is to tell the DMA layer how much combining
>> IOMMU can do.
>
> Disagree; this is a dodgy hack, since you'll now end up passing scatterlists into dma_map_sg() which already violate max_seg_size to begin with, and I think a conscientious DMA API implementation would be at rights to fail the mapping for that reason (I know arm64 happens not to, but that was a deliberate design decision to make my life easier at the time).
>
> As a short-term fix, at least do something like what i915 does and constrain the table allocation to the desired segment size as well, so things remain self-consistent. But still never claim that faking a hardware constraint as a workaround for a driver shortcoming is "the right thing to do" ;)
You are asking for something like this from here, right?
https://elixir.bootlin.com/linux/v4.16.1/source/drivers/gpu/drm/i915/i915_gem_dmabuf.c#L58
ret = sg_alloc_table(st, obj->mm.pages->nents, GFP_KERNEL);
if (ret)
goto err_free;
src = obj->mm.pages->sgl;
dst = st->sgl;
for (i = 0; i < obj->mm.pages->nents; i++) {
sg_set_page(dst, sg_page(src), src->length, 0);
dst = sg_next(dst);
src = sg_next(src);
}
This seems to allocate the scatter gather list and fill it in manually before passing it
to dma_map_sg(). I'll give it a try.
Just double checking.
>
> Robin.
>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-04-11 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 20:59 [PATCH V2] drm/amdgpu: limit DMA size to PAGE_SIZE for scatter-gather buffers Sinan Kaya
2018-04-11 6:26 ` Huang Rui
2018-04-11 9:17 ` Christian König
2018-04-11 12:03 ` Robin Murphy
2018-04-11 14:33 ` Sinan Kaya [this message]
2018-04-11 15:32 ` Robin Murphy
2018-04-12 6:26 ` Christoph Hellwig
2018-04-12 9:42 ` Christian König
2018-04-12 13:51 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a1d0069-c8d3-cc0d-cf1c-8e90e4a2b0d7@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=David.Panariti@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Emily.Deng@amd.com \
--cc=Feifei.Xu@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hongbo.He@amd.com \
--cc=Jim.Qu@amd.com \
--cc=Monk.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=robin.murphy@arm.com \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).