From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257AbcHWKQf (ORCPT ); Tue, 23 Aug 2016 06:16:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:50867 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbcHWKQd (ORCPT ); Tue, 23 Aug 2016 06:16:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,565,1464678000"; d="scan'208";a="159746139" Subject: Re: [PATCH v13 4/7] drm/i915/skl: Update plane watermarks atomically during plane updates To: Lyude References: <6048370c-fd04-4a73-8e79-44a90c08b1e4@linux.intel.com> <1471884608-10671-1-git-send-email-cpaul@redhat.com> Cc: stable@vger.kernel.org, =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Daniel Vetter , Radhakrishna Sripada , Hans de Goede , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Maarten Lankhorst Message-ID: <1a236eb1-0237-0fb5-1525-3e6c1546cdd0@linux.intel.com> Date: Tue, 23 Aug 2016 12:16:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471884608-10671-1-git-send-email-cpaul@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 22-08-16 om 18:50 schreef Lyude: > Thanks to Ville for suggesting this as a potential solution to pipe > underruns on Skylake. > > On Skylake all of the registers for configuring planes, including the > registers for configuring their watermarks, are double buffered. New > values written to them won't take effect until said registers are > "armed", which is done by writing to the PLANE_SURF (or in the case of > cursor planes, the CURBASE register) register. Applied, thanks. Can you resend 6/7 and 7/7?