From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "cy_huang(黃啟原)" <cy_huang@richtek.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [RFT PATCH 0/2] regulator: richtek,rt4801: use existing ena_gpiod feature
Date: Fri, 1 Apr 2022 22:36:04 +0200 [thread overview]
Message-ID: <1a26fd19-0f5e-d9f1-08e7-c5e3edd610a1@linaro.org> (raw)
In-Reply-To: <1648831895.12596.6.camel@richtek.com>
On 01/04/2022 18:51, cy_huang(黃啟原) wrote:
>
> 於 五，2022-04-01 於 17:42 +0200，Krzysztof Kozlowski 提到：
>> Hi,
>>
>> Not tested.
>>
>> Follow up of discussion:
>> https://lore.kernel.org/all/2d124d53-1f36-5315-3877-af8f8ad5f824@linaro.org/#t
>> <https://lore.kernel.org/all/2d124d53-1f36-5315-3877-af8f8ad5f824@linaro.org/#t
>> >
>
> If RT4801 enable-gpio both go from high to low, the voltage reg will be
> reset, and I2C cannot be accessibele.
> This patch can be used to individually control enable for DSVP and DSVN,
> but the above i2c behavior is not considered.
> You can check rt4801_enable/rt4801_disable for the details.
Ah, so this is why this custom enable methods is there (pus bitmap etc).
Then the core ena_gpiod cannot be used, although still we want to move
on from two GPIOs in one enable-gpios property.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-04-01 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 15:42 [RFT PATCH 0/2] regulator: richtek,rt4801: use existing ena_gpiod feature Krzysztof Kozlowski
2022-04-01 15:42 ` [RFT PATCH 1/2] regulator: dt-bindings: " Krzysztof Kozlowski
2022-04-04 21:42 ` Rob Herring
2022-04-01 15:42 ` [RFT PATCH 2/2] regulator: " Krzysztof Kozlowski
[not found] ` <1648831895.12596.6.camel@richtek.com>
2022-04-01 20:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a26fd19-0f5e-d9f1-08e7-c5e3edd610a1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).