From: Andre Przywara <andre.przywara@arm.com>
To: tglx@linutronix.de, Marc Zyngier <marc.zyngier@arm.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Samuel Holland <samuel@sholland.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [linux-sunxi] Re: [PATCH 0/2] Allwinner A64 timer workaround
Date: Wed, 4 Jul 2018 14:08:17 +0100 [thread overview]
Message-ID: <1a36f63c-0259-bdcd-bb96-d5230c2564ea@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1807041151530.1816@nanos.tec.linutronix.de>
Hi,
On 04/07/18 11:00, Thomas Gleixner wrote:
> On Wed, 4 Jul 2018, Marc Zyngier wrote:
>> On 04/07/18 09:23, Daniel Lezcano wrote:
>>>
>>> If the patches fix a bug which already exist, it makes sense to
>>> propagated the fix back to the stable versions.
>>
>> That's your call, but I'm not supportive of that decision, specially as
>> we have information from the person developing the workaround that this
>> doesn't fully address the issue.
>
> The patches should not be applied at all. Simply because they don't fix the
> issue completely.
>
> From a quick glance at various links and information about this, this very
> much smells like the FSL_ERRATUM_A008585.
> Has that been tried? It looks way more robust than the magic 11 bit
> crystal ball logic.
The Freescale erratum is similar, but not identical [1].
It seems like the A64 is less variable, so we can use a cheaper
workaround, which gets away with normally just one sysreg read. But then
again the newer error reports may actually suggest otherwise ...
And as it currently stands, the Freescale erratum has the drawback of
relying on the CPU running much faster than the timer. The A64 can run
at 24 MHz (for power savings, or possibly during DVFS transitions),
which is the timer frequency. So subsequent counter reads will never
return the same value and the workaround times out.
Cheers,
Andre.
[1] https://lists.denx.de/pipermail/u-boot/2016-November/271836.html
next prev parent reply other threads:[~2018-07-04 13:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 2:27 [PATCH 0/2] Allwinner A64 timer workaround Samuel Holland
2018-05-11 2:27 ` [PATCH 1/2] arm64: arch_timer: Workaround for Allwinner A64 timer instability Samuel Holland
2018-05-11 8:26 ` Maxime Ripard
2018-05-11 8:48 ` Marc Zyngier
2018-05-11 15:08 ` Samuel Holland
2018-05-26 15:15 ` André Przywara
2018-05-11 2:27 ` [PATCH 2/2] arm64: dts: allwinner: a64: Enable A64 timer workaround Samuel Holland
2018-05-11 9:24 ` [PATCH 0/2] Allwinner " Andre Przywara
2018-07-03 15:09 ` Marc Zyngier
2018-07-03 18:42 ` Samuel Holland
2018-07-04 8:16 ` Marc Zyngier
2018-07-04 8:19 ` Chen-Yu Tsai
2018-07-04 8:23 ` Daniel Lezcano
2018-07-04 8:39 ` Marc Zyngier
2018-07-04 10:00 ` Thomas Gleixner
2018-07-04 13:08 ` Andre Przywara [this message]
2018-07-04 14:31 ` [linux-sunxi] " Thomas Gleixner
2018-07-04 14:44 ` Andre Przywara
2018-07-04 15:01 ` Marc Zyngier
2018-07-04 15:15 ` Andre Przywara
2018-07-04 15:30 ` Marc Zyngier
2018-07-04 15:23 ` Samuel Holland
2018-07-04 15:14 ` Thomas Gleixner
2018-07-04 15:43 ` Andre Przywara
2018-07-04 19:49 ` Thomas Gleixner
2018-07-04 8:41 ` Daniel Lezcano
2018-07-12 2:23 ` Samuel Holland
2018-07-04 9:06 ` Maxime Ripard
2018-07-04 8:41 ` Daniel Lezcano
2018-07-04 12:52 ` [linux-sunxi] " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a36f63c-0259-bdcd-bb96-d5230c2564ea@arm.com \
--to=andre.przywara@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=marc.zyngier@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=samuel@sholland.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).