From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA88FC07E9D for ; Thu, 29 Sep 2022 09:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235186AbiI2JNQ (ORCPT ); Thu, 29 Sep 2022 05:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235663AbiI2JMy (ORCPT ); Thu, 29 Sep 2022 05:12:54 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A37F614356E for ; Thu, 29 Sep 2022 02:12:29 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id q17so828891lji.11 for ; Thu, 29 Sep 2022 02:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=fn6aAyOFSjJqLQMDfUAvbicJg1NvuDMq2C6asryaSFo=; b=pOO5e3pewQt/deLNDXyGdnUSOSDsrMOf2TcP+injiwm/IW+JxjU1A3TuOoL+gezmDc ILHN9PHvn/tU0pzwXrRZ5884Jm5aAzrC2yWkg2Jo0KpIU+TrGTO9Myo2Xw2n2KcHq7Jj OfV3rTWxclVwH2OJiBy0kcvQBPE7pncXDmTpWI+YacZZoI+W5JgSnnkH3kzWhHUx135t KJPttLjtRoGeQcohVUEGF/i1jNefJfUaa7Q4v0KZSkyWrMnygW2vPlQd7Va0GEh/fVTA 6U1PFTsuBNsFTKkS9iWfIzCQ2RTQw3fQ+mvyPhM8yAGGdaCmg9eU64skW3tJAD9r48Wr 2cog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=fn6aAyOFSjJqLQMDfUAvbicJg1NvuDMq2C6asryaSFo=; b=XLIme5kxkDlwB4tf4kSWklkBsS/HJaWIUJb+tZsZ/PxruxkBeKgXaTS0hZbccE9dQA Tihs/FKbihOKjDyzLF778AffW7w1kgRBQ9KkVvQDUkqGX6+eh5m+OGXbpzA+u6xaAc9Y lEat2QuFZjyhqoslLeKnaMfZcSo8+IfYoOpif9R2fTuE8TqCDqf8vItg7xDaH9/5vsbQ RrPNR64nOCSiOlmWXKY7oOH6SPyuFEAEqRNFO53mJlY6XU1yLYnoDn9bIMkjL0K/TzqQ /VliFnvS+Yqi18l5zBeKj388JdIA+DI41/g839cwiCuwdMej4Dls/FcU694tNsJ3nLsl UdKg== X-Gm-Message-State: ACrzQf0FXHNh5fsHWvLQu8tYo4F+5Po5n9CX9U8qFS+UyYH9QQw/tpfn IIaRlXA0xKq+MfoLiRztCfl5Pw== X-Google-Smtp-Source: AMsMyM5s6g4sulwufXRhT+Ug/QBUz9Y7qn+TSCqYCPR2ZgZOiel4lm73cphufi5uOpuoH62fa10ezQ== X-Received: by 2002:a2e:a7ca:0:b0:26c:51d6:55ed with SMTP id x10-20020a2ea7ca000000b0026c51d655edmr737468ljp.426.1664442746238; Thu, 29 Sep 2022 02:12:26 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u4-20020a056512128400b0048a982ad0a8sm729228lfs.23.2022.09.29.02.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 02:12:25 -0700 (PDT) Message-ID: <1a3c6766-9be5-1e55-95eb-bc9656e5c9a3@linaro.org> Date: Thu, 29 Sep 2022 11:12:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Content-Language: en-US To: neil.armstrong@linaro.org, Andy Gross , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Konrad Dybcio Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org> <20220928-mdm9615-dt-schema-fixes-v1-5-b6e63a7df1e8@linaro.org> <0636d53f-508f-8a86-0973-2641c9020622@linaro.org> <6ed642ea-424d-49ed-eb30-e09588720373@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <6ed642ea-424d-49ed-eb30-e09588720373@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2022 10:29, Neil Armstrong wrote: > Hi, > > On 28/09/2022 20:03, Krzysztof Kozlowski wrote: >> On 28/09/2022 11:14, Neil Armstrong wrote: >>> The PMIC is an PM8018, but was compatible with the PM8921. Both compatibles >>> was left but it makes no sense anymore the leave both. >> >> Why? It makes sense for backwards compatibility. If you think it does >> not make sense, please say why. > > We had the same debate at submission 7y ago, some of the pm8018 new compatible > were rejected in bindings & drivers so I left both... > > As of today only the pwrkey bindings is missing, so should I resubmit the pm8018-pwrkey bidings and > drop the pm8921-pwrkey compatible ? ~7 years ago here: https://lore.kernel.org/all/20160624220748.GB11719@dtor-ws/ you proposed to add something entirely different than we have here now and than we talk about. In that thread you correctly wrote: "My point of view is that the devicetree describes the hardware and need to have SoC specific compatible string since it describes the actual silicon, and drivers must make sure to handle all the SoC or family variants using the compatible string and the match data." but implemented it entirely different. Maybe you refer to different mail thread, I don't know, but that one is indeed wrong. The DTS looks correct unless you have some real argument that it is not. How this should be fixed? First, drop bogus entries from drivers, then document proper compatibles. Best regards, Krzysztof