From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFA5C33CB1 for ; Thu, 16 Jan 2020 16:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7662C20728 for ; Thu, 16 Jan 2020 16:11:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ExBAWBlQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbgAPQL4 (ORCPT ); Thu, 16 Jan 2020 11:11:56 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:26364 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbgAPQL4 (ORCPT ); Thu, 16 Jan 2020 11:11:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579191115; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=XW8XoFw5PNL4iewPQecr5FNhrMV0FYDDvOpMYIAPAHQ=; b=ExBAWBlQRzHwCbfEbi/hmde6GcYK4mQ3tGZSn7EhWPDFjF7KG4xFFdl7jV1bBdlOgXpLk1uX 5QqTnHzLQ4Th1g61HUeGaqhlh7N+QIuP5ZEj/8au+IV75aYvKrNLaMAH+hMKI/VYibcbuhoi 9Aj2sYEh6B8caI8G2StaQ8VnyOE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e208b48.7f9d668ebce0-smtp-out-n02; Thu, 16 Jan 2020 16:11:52 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E3D33C433A2; Thu, 16 Jan 2020 16:11:50 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4346EC43383; Thu, 16 Jan 2020 16:11:50 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Jan 2020 21:41:50 +0530 From: Sai Prakash Ranjan To: Will Deacon Cc: jhugo@codeaurora.org, Catalin Marinas , Marc Zyngier , Andre Przywara , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Douglas Anderson , Stephen Boyd , Bjorn Andersson , Matthias Kaehlcke , James Morse Subject: Re: [PATCH] arm64: Add KRYO{3,4}XX CPU cores to spectre-v2 safe list In-Reply-To: <20200116153235.GA18909@willie-the-truck> References: <20200116141912.15465-1-saiprakash.ranjan@codeaurora.org> <20200116153235.GA18909@willie-the-truck> Message-ID: <1a3f9557fa52ce2528630434e9a49d98@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On 2020-01-16 21:02, Will Deacon wrote: > [+Jeffrey] > > On Thu, Jan 16, 2020 at 07:49:12PM +0530, Sai Prakash Ranjan wrote: >> KRYO3XX silver CPU cores and KRYO4XX silver, gold CPU cores >> are not affected by Spectre variant 2. Add them to spectre_v2 >> safe list to correct ARM_SMCCC_ARCH_WORKAROUND_1 warning and >> vulnerability sysfs value. >> >> Signed-off-by: Sai Prakash Ranjan >> --- >> arch/arm64/include/asm/cputype.h | 6 ++++++ >> arch/arm64/kernel/cpu_errata.c | 3 +++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/arch/arm64/include/asm/cputype.h >> b/arch/arm64/include/asm/cputype.h >> index aca07c2f6e6e..7219cddeba66 100644 >> --- a/arch/arm64/include/asm/cputype.h >> +++ b/arch/arm64/include/asm/cputype.h >> @@ -85,6 +85,9 @@ >> #define QCOM_CPU_PART_FALKOR_V1 0x800 >> #define QCOM_CPU_PART_FALKOR 0xC00 >> #define QCOM_CPU_PART_KRYO 0x200 >> +#define QCOM_CPU_PART_KRYO_3XX_SILVER 0x803 >> +#define QCOM_CPU_PART_KRYO_4XX_GOLD 0x804 >> +#define QCOM_CPU_PART_KRYO_4XX_SILVER 0x805 > > Jeffrey is the only person I know who understands the CPU naming here, > so > I've added him in case this needs either renaming or extending to cover > other CPUs. I wouldn't be at all surprised if we need a function call > rather than a bunch of table entries... > > That said, the internet claims that KRYO4XX gold is based on > Cortex-A76, > and so CSV2 should be set... > Yes the internet claims are true and CSV2 is set. SANITY check logs in here show ID_PFR0_EL1 - https://lore.kernel.org/patchwork/patch/1138457/ Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation