From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F07C433E0 for ; Thu, 7 Jan 2021 10:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 580BD2312F for ; Thu, 7 Jan 2021 10:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbhAGKdL convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2021 05:33:11 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]:29472 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbhAGKdK (ORCPT ); Thu, 7 Jan 2021 05:33:10 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-6-SCUAd1AEPyGpzrF_WGAUQw-1; Thu, 07 Jan 2021 10:31:31 +0000 X-MC-Unique: SCUAd1AEPyGpzrF_WGAUQw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 7 Jan 2021 10:31:31 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 7 Jan 2021 10:31:31 +0000 From: David Laight To: 'Peter Zijlstra' , Randy Dunlap CC: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "jpoimboe@redhat.com" , "sfr@canb.auug.org.au" , "tony.luck@intel.com" Subject: RE: [PATCH 7/6] x86: __always_inline __{rd,wr}msr() Thread-Topic: [PATCH 7/6] x86: __always_inline __{rd,wr}msr() Thread-Index: AQHW5N7SY2UD6xEyu0aMJREnibyUraob9aBw Date: Thu, 7 Jan 2021 10:31:31 +0000 Message-ID: <1a46f52f696f422ab95f31733e638f76@AcuMS.aculab.com> References: <20210106143619.479313782@infradead.org> <20210106144017.532902065@infradead.org> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra > Sent: 07 January 2021 10:18 ... > -static inline unsigned long long notrace __rdmsr(unsigned int msr) > +static __always_inline unsigned long long __rdmsr(unsigned int msr) Since we (should) only request 'inline' for things that need to be inlined, maybe inline should expand to __attribute__((always_inline)). That might throw up a few warnings where inline has been misused. But they are less problematic than things not being inlined. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)