From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] Calling check_system_tsc_reliable() before unsynchronized_tsc()
Date: Fri, 23 Jun 2017 16:30:25 +0800 [thread overview]
Message-ID: <1a53c844-3724-e8e8-2aff-c494a5acb493@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1706221538570.1885@nanos>
在 2017/6/22 21:56, Thomas Gleixner 写道:
> Zhenzhong,
>
> On Wed, 21 Jun 2017, Zhenzhong Duan wrote:
>
> So the patch format is now correct, but the subject line is missing a
> proper subsystem prefix. Please use 'git log 'path/to/patched/file' next
> time to see what the usually used prefix for a file is.
>
> In this case it's: x86/tsc
>
> Also please do not use [PATCH RESEND] when your patch is different from the
> version you sent before. Please use [PATCH v2] instead.
Got it.
>
>> unsynchronized_tsc() checks value of tsc_clocksource_reliable which is set by
>> check_system_tsc_reliable(). It's better to move check_system_tsc_reliable() at
>> front.
> Please make your statements affirmative. 'It's better' is a weak expression.
>
>> Though X86_FEATURE_CONSTANT_TSC is usually set for TSC reliable system, just in
>> case.
> So what you wanted to say here is:
>
> tsc_clocksource_reliable is initialized in check_system_tsc_reliable(),
> but it is checked in unsynchronized_tsc() which is called before the
> initialization.
>
> In practice that's not an issue because systems which mark the TSC
> reliable have X86_FEATURE_CONSTANT_TSC set as well, which is evaluated
> in unsynchronized_tsc() before tsc_clocksource_reliable.
>
> Reorder the calls so initialization happens before usage.
Exactly.
>
> All this information is also documented in Documentation/process/.
I'll read them.
>
> No need to resend. I'll fix it up for you this time.
Ok, thanks.
zduan
next prev parent reply other threads:[~2017-06-23 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 8:23 [PATCH RESEND] Calling check_system_tsc_reliable() before unsynchronized_tsc() Zhenzhong Duan
2017-06-22 13:56 ` Thomas Gleixner
2017-06-23 8:30 ` Zhenzhong Duan [this message]
2017-06-22 14:03 ` [tip:x86/timers] x86/tsc: Call " tip-bot for Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a53c844-3724-e8e8-2aff-c494a5acb493@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).