From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbdLEPZR (ORCPT ); Tue, 5 Dec 2017 10:25:17 -0500 Received: from mx0b-00190b01.pphosted.com ([67.231.157.127]:44210 "EHLO mx0b-00190b01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbdLEPZM (ORCPT ); Tue, 5 Dec 2017 10:25:12 -0500 Subject: Re: waitqueue lockdep annotation To: Christoph Hellwig Cc: Andrew Morton , Ingo Molnar , Peter Zijlstra , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso References: <20171130142037.19339-1-hch@lst.de> <20171130125050.1faba3f06fc572846f792f17@linux-foundation.org> <20171130221126.GA31795@lst.de> <21c34413-d178-fda0-91b2-6ab02c6d5a06@akamai.com> <20171201171102.GA20072@lst.de> <57869c0c-764c-ff99-93cd-8020f8ceea9e@akamai.com> <20171201220239.GA32542@lst.de> <2fd9dc6b-9201-67db-b81e-a783daf0ce50@akamai.com> <20171201230336.GA4446@lst.de> From: Jason Baron Message-ID: <1a5d4610-b84e-ba29-b5bb-b80e19fc17b7@akamai.com> Date: Tue, 5 Dec 2017 10:24:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171201230336.GA4446@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712050222 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712050221 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2017 06:03 PM, Christoph Hellwig wrote: > On Fri, Dec 01, 2017 at 05:34:50PM -0500, Jason Baron wrote: >> hmmm...I'm not sure how this suggestion would change the locking rules >> from what we currently have. Right now, we use ep->lock, if we remove >> that and use ep->wq->lock instead, there is just a 1-to-1 mapping there >> that has not changed, since ep->wq->lock currently is completely not >> being used. > > True. The patch below survives the amazing complex booting and starting > systemd with lockdep enabled test. Do we have something resembling a > epoll test suite? > I don't think we have any in the kernel tree proper (other than some selftests using epoll) but there are tests in ltp and some performance tests such as: http://linux-scalability.org/epoll/epoll-test.c http://www.xmailserver.org/linux-patches/pipetest.c Thanks, -Jason