From: Asutosh Das <asutoshd@codeaurora.org>
To: subhashj@codeaurora.org, cang@codeaurora.org,
vivek.gautam@codeaurora.org, rnayak@codeaurora.org,
vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 7/9] scsi: ufs: make sure all interrupts are processed
Date: Wed, 21 Feb 2018 10:26:38 +0530 [thread overview]
Message-ID: <1a8aaa1b5770fac1e2223dd08a1a80c440748317.1519120988.git.asutoshd@codeaurora.org> (raw)
In-Reply-To: <cover.1519120988.git.asutoshd@codeaurora.org>
In-Reply-To: <cover.1519120988.git.asutoshd@codeaurora.org>
From: Venkat Gopalakrishnan <venkatg@codeaurora.org>
As multiple requests are submitted to the ufs host controller in
parallel there could be instances where the command completion
interrupt arrives later for a request that is already processed
earlier as the corresponding doorbell was cleared when handling
the previous interrupt. Read the interrupt status in a loop after
processing the received interrupt to catch such interrupts and
handle it.
Signed-off-by: Venkat Gopalakrishnan <venkatg@codeaurora.org>
Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 27 +++++++++++++++++++--------
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 987b81b..4d4c7d6 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5406,19 +5406,30 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)
u32 intr_status, enabled_intr_status;
irqreturn_t retval = IRQ_NONE;
struct ufs_hba *hba = __hba;
+ int retries = hba->nutrs;
spin_lock(hba->host->host_lock);
intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
- enabled_intr_status =
- intr_status & ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
- if (intr_status)
- ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
+ /*
+ * There could be max of hba->nutrs reqs in flight and in worst case
+ * if the reqs get finished 1 by 1 after the interrupt status is
+ * read, make sure we handle them by checking the interrupt status
+ * again in a loop until we process all of the reqs before returning.
+ */
+ do {
+ enabled_intr_status =
+ intr_status & ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
+ if (intr_status)
+ ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
+ if (enabled_intr_status) {
+ ufshcd_sl_intr(hba, enabled_intr_status);
+ retval = IRQ_HANDLED;
+ }
+
+ intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
+ } while (intr_status && --retries);
- if (enabled_intr_status) {
- ufshcd_sl_intr(hba, enabled_intr_status);
- retval = IRQ_HANDLED;
- }
spin_unlock(hba->host->host_lock);
return retval;
}
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-02-21 5:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1519120988.git.asutoshd@codeaurora.org>
2018-02-21 4:56 ` [PATCH 1/9] scsi: ufs: Allowing power mode change Asutosh Das
2018-02-23 5:10 ` Kyuho Choi
2018-02-23 7:03 ` Asutosh Das (asd)
2018-02-21 4:56 ` [PATCH 2/9] scsi: ufs: Add LCC quirk for host and device Asutosh Das
2018-02-21 4:56 ` [PATCH 3/9] scsi: ufs: fix exception event handling Asutosh Das
2018-02-21 4:56 ` [PATCH 4/9] scsi: ufshcd: fix possible unclocked register access Asutosh Das
2018-02-21 4:56 ` [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests Asutosh Das
2018-02-21 13:18 ` Stanislav Nijnikov
2018-02-23 2:31 ` Asutosh Das (asd)
2018-02-21 4:56 ` [PATCH 6/9] scsi: ufs-qcom: remove broken hci version quirk Asutosh Das
2018-02-21 4:56 ` Asutosh Das [this message]
2018-02-21 4:56 ` [PATCH 8/9] scsi: ufs: fix irq return code Asutosh Das
2018-02-21 4:56 ` [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue Asutosh Das
2018-02-23 23:57 ` Miguel Ojeda
2018-02-26 3:55 ` Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a8aaa1b5770fac1e2223dd08a1a80c440748317.1519120988.git.asutoshd@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=venkatg@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).