From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbdE3Psv (ORCPT ); Tue, 30 May 2017 11:48:51 -0400 Received: from mail-co1nam03on0048.outbound.protection.outlook.com ([104.47.40.48]:30026 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750720AbdE3Psr (ORCPT ); Tue, 30 May 2017 11:48:47 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption To: Josh Poimboeuf , Borislav Petkov CC: , , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418212223.10190.85121.stgit@tlendack-t1.amdoffice.net> <20170519113005.3f5kwzg4pgh7j6a5@pd.tnic> <20170519201651.dhayf2pwjlsnouz4@treble> From: Tom Lendacky Message-ID: <1ac40d18-a8b2-94eb-35ed-c30768667be8@amd.com> Date: Tue, 30 May 2017 10:48:27 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170519201651.dhayf2pwjlsnouz4@treble> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: BN6PR14CA0032.namprd14.prod.outlook.com (10.171.172.146) To CY4PR12MB1141.namprd12.prod.outlook.com (10.168.163.149) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR12MB1141: X-MS-Office365-Filtering-Correlation-Id: cbf2a14e-003f-452d-886d-08d4a7735a9a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;3:79mfzLGdXkHrqttqf+durrEW+e28LuXztl6mblB1L60MMNs7saaz8O0IhqPa8PmvNXkK9grcK1CpIXAQ2RxNPDytJ6RyYEtTNXXJrXreqb8Hh7kNzrvWgW+97pNhGanADOhVBTdnHERPlF/ozDKA4GzmzyUIYyXxrzTONk4/D8NjGGHik+jBA+bSYaGngWNvIolQr5d6ujpVPaDwW6DFazPoPolETHnVR6BGpnNCVQf2WOiJNzGE+tInpp0mqEHzp+EC9NWJ0P5JKN59nh9X6VwphFaHtjcNq/jfePvdNG3nmBllaf6pPOA6WKJxU4ySFIsIRKDoSw0rpG8HL2ZqnxMAieda7vHiJVD1DcHRlzk=;25:jjYmn4Wy7B7fehwXfd+pnHwIjY5EGpFjtWQhZ6plTfd7l9kJtmHVYVEnO5iDM2Yj0hC4HqMJbNxhLtezH6/20ySs+P6EQqqMEFA/0r5VxuOZg/iXtgDRAAfsFol+JMKxRtVmpJ2jdOu6UV00NbX9OCPu5ZvLznVPJ3w4lsQ1Gyw8LlRJF3Q8EHG6O06WPgPTVZoChnPePSZTHsznshv/KKSFMWodAAGOmk12WNvjYRKBzYe3JNTK7Or5zJjHj5m1PE+mcqfTT/9au+AXtURybjwVNDoRhhaFVRyqIZ21sMsGvcs+gDmu+5rSFMTVuAgn9yp9nzUkLr76yVzekA2DLFg6gYxzMmT70Tf2YjQ/zP591V/MJnRN0ozKJq1N0Hx1Qk2jE5C9OaxmOY8eUL7jYVvoy21h4WPSonsFDOP/bNv7ruv6MOwth/+I3vNetjErhwQUKAS5D7WXCoyABfC97vuLBzoeIz407BvvxX4vZUE= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;31:x5ADztqh+3EvBGgl+oc3KqU3RFdDMtjOXL81P/qE+/bP9vL6u8gFaUThiQQk57Hn2LLGRun03B0lwJdptCbkWXr5WX2j8rv13E812USQoc+Q5QHI3hf8NtRjADl0xMLtRfiTJIvqamiD/74HWtuwcPGIuGJC4Mqz3Ix8XBBEo7fiRSL5HDa6TB2pEWSY2He1kShG8NbFL982+V12oK/eD8oyi3wzVnVWa7RoA3LeYUA=;20:xaqSNnH5vEPncW8IIdINYjowr7oGQwsF51D0pnAp48RlgK8PSQaT/5uY+wc7vA/bjRdz/0Ng0pC1uuCEE8V1w3bWc68O80KG96jUYWSDAnwr1REI/Qti4itBiyobaB9fuh3lKNUQqViqi1ygQ2hBBoyACuYGF2p4+YHEjlTRi6ZLT6gsXV6DSNwBP+Zuw7nauC0HYyBEM6dRPWtsyAI+GzNs8B978bPykq9nwRHnlbv6VTGIYUg9hEuVhtXka3HNtbvvr2/V5iYIOG9KskIM3kM+T0a/roXql2FygI+QD7nm8SLVNUXT19xPBeQ/7NtuafEHhL35sLJGgcKsFC7JRzzNzB5CiuFSiYTUhCL1dnrdbTgXTfBVsyna744Ytu4glutt5XV/9/9y1ItZuzuX58vRSO2dlERrV3snhcuHqDni3m87VxS5lKLe5OW9Wa1kE8TqbhrWmJVyX6oNLj6+7V4lBLN5/JJOYp1Om8r6bf3Ov9abmVkKMv0PCJO1/3EP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(6072148);SRVR:CY4PR12MB1141;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1141; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;4:X0Vpk9q+cd9bu6MmkC7lih+gzA0AJbEd9YtzDau/u78Alz6DYW39nrPIjqsMWFOzJZZodhS0skrfCB1fYYWkAWLgouBcGQhHyt5ijVt8rf2Q5zHn9x8Og4jmmtc9ZAeYfJdHybDLyPl4PgXFPgwT/Nnii88K7XigoZ+k5GwuNXnJvYgued5mj5L43bo9pVeKjGh9CTYLvjti+ixkTIdEWmh/hkgLrEbjZudaeXkvNrTNG8uqKXFh+JpC8SO+0/UZCmWT90cljXPB6UX8uFO+1/3eCwxrevVtUsz0D2ns4mNRdgcOT9AuFzaYDzKGgW5Ld/FNKFr5efXWR0V/GO8e+EicPfBSuKviVTXRXWMcvUGMbG5T/d8iVMdMdspWCfSPN+yzE4hqzXihMfI8bbvkgoFmwEBL8wqmosw23p+tJ2iTZ8LbI2IO/hZgWPexnzo/qMDf1wWQOTo7s5RPOBeYbgWaERS7SL0mWLLGDk4gJHQdTk9VzdShLP/G6fi2whlaEj5/IwbeDL0Q+m0N7rzDnAw3jZ3ELQhHtjI0BscmDIoOjgl7d7XHjLqBYgUsklnbmPRa4MGKo+Rq5MFYAgQs5/bIYTT7HGg5ELaFop4M5GfYQtKq9zz1vIhNafLpHB23ttx3zfVonrwbPZVgwtTnQ0VJdbkSTDzknet+rJEwQi9MlcYdmzscnPhmBHHhMu0wVJML5n9TMhj/3lE5wM9vNg58bZtjRCEqYK1+7FYaVd1gALHx1cC0tq9stXuLu0z1w7CWOgISifR5DT2XyqqUuHWbPSdcK1Oyz7NRKY5r/xnopXeds2C9IRoBndpj4zG6 X-Forefront-PRVS: 032334F434 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39400400002)(39410400002)(39850400002)(39450400003)(39840400002)(39860400002)(377454003)(24454002)(76176999)(50986999)(5660300001)(6666003)(4001350100001)(2950100002)(86362001)(31696002)(229853002)(6116002)(93886004)(36756003)(66066001)(81166006)(31686004)(4326008)(25786009)(53546009)(189998001)(83506001)(8676002)(42186005)(3846002)(230700001)(7736002)(305945005)(23676002)(47776003)(2906002)(65826007)(90366009)(7406005)(33646002)(64126003)(7416002)(478600001)(77096006)(72206003)(54906002)(6486002)(6246003)(38730400002)(54356999)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1141;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQxOzIzOkRoRDVZSDZ5K2tyZStYTWxnWWdudXlyOUR4?= =?utf-8?B?MEJ0blhnSFQrbjQxcFdPSmZjWkExMWY1QVhwQjFSekNocjQ4UGFMWnMvYW9s?= =?utf-8?B?aEwxb0cyWndheWN4enNHU2hFVGhLRkwySHk2b3Y0VmtldEhqbk9PeFZsZ250?= =?utf-8?B?N2w5VnNaMHN1ZW5CY2lVYXc0TFJxYTFCWE1pb3BnNEVoNG9XYWg1ZE1kQVV3?= =?utf-8?B?c1laV2orSGRaZ3dWL2R0WUVqYmRUcGFJMVd5ZUcycytMZTg3dlZhNzFpQlYw?= =?utf-8?B?WnpCRWwzbE8zalNvR3IvVjRNYVMwSFl5Zk11SlVyc0JrOGhSQTVWdzRpSmpm?= =?utf-8?B?Q2p4ek11Nkx3N1N4TGZtWk1NeWR1cGJKSnVRYjFmWXlNbnRiYzY0NUMveklO?= =?utf-8?B?NlNKK2FqWnFXcUpiTGdUWGdOQUdxYndXa08yS1NLMUNncFlHSm1aUFZyclV0?= =?utf-8?B?L0kxckNTMU5jTGxKeGF5Rk1oNFNDVlVVSGc0RVJRYVRWaWljMExPQWlrRG8v?= =?utf-8?B?STgxOGt1eHNZL1hTSGxwRjVydmo5Z0lHVWJJV1lyV0hvQ0IvOWY3dDJyUXph?= =?utf-8?B?bXlhT3RoOEo4V0IxT2VTcnZ0Q0grNGx3aGtrOEhrNmNKOTVsWjVOdGVOdXlZ?= =?utf-8?B?bW1QZUxFQ2IwYW9vMnpGdE9tbVF6Yk9nSzM4OC9NZndWKzFIaUZYeXdiSWFK?= =?utf-8?B?cWdMNHp6dzMvaEFTODVXd04vaWRZNFR4eUVWbVdxYW5INDJWRSs2WWZhczFa?= =?utf-8?B?TnlmRk9EcmdjalJiYXMrWUZJVGxYRWJDYjJ0Q1NPZFA0U2h3L1l6dWdwUWt2?= =?utf-8?B?S1JDNm55VmlDM0xIai8xWHB0OW1lM3lXMENGKzJPbGYvaE1IbU0yZDU5L05i?= =?utf-8?B?SWQzc21DZWN6YlhTUTdiOUw2WXBRZ3ZLQURsZVNwMGhqeFllUlBxeDFjV3Bm?= =?utf-8?B?SzNPVnN4NERjTVR0WmZSMmo4ZzJrYkE4Ym5NOSsrc25lKzkwK3N6UEFqSGZQ?= =?utf-8?B?SUx5eFhxc2hEOWluU1lkMDRFWDNHcWlBd0JZZ1VDS0NJRjh6MTg3ckFjZ09D?= =?utf-8?B?YjljTUFsOWkvc2JWM2xHZUlDMjJZL3VVakFpMWMybE9BTDJTM3oySEVTMnNK?= =?utf-8?B?VjdPczRCNUJCSVU1RmhLdzhxdzA3MWo1T2ZnZUdDYzN4N1lYcFA4eWFtU3Fx?= =?utf-8?B?elVsaWRQWEVlcEFaeVpBbGJWOTZwSDlyamtvajd4Ry9qMTNtU1lSbll5UUN3?= =?utf-8?B?RGVyM0xMUlZoUTJuazdiZDVvQUlrYXRpMVBOR0syd3lVdGZtcnhPZWg1b1Y2?= =?utf-8?B?blNrRGRnWjh5ckFHNnF5cVErV3NMdlNqb044cVUrczkvajlIUUZhMTlwNi9x?= =?utf-8?B?eUZNSmpHUjV0aDE5OTZWa3dXT3dtcVlyWWtjUGFiU2FpUGFUWHl2cEgvYkNT?= =?utf-8?B?anorNmZsSFdzQ2NyQjZuQjhIWTJWTUpld2oySUZGd0hSZjEwZVlDWFI1aXV5?= =?utf-8?B?MCt6bFpSZTFGSFlxNUd4TUhYZ2RCNjNPZ0xQakp2NVhpdmllZit2bVArR0Ni?= =?utf-8?B?Z3VjWnpienBsWlFER3FOMzBZTVR0eXFER2JlWklaU1NSUWdCNy9HL0R6cTZN?= =?utf-8?B?TDdBaW9oNVU0WHZXVVAxUkp2elZsS21RdjR5VmVHZmJPcVlGeWJWbmJVQzdn?= =?utf-8?B?VVVTZnR4bENWMDNZWWdsV2VKWWJESjd2MGZnVnNWMlp5TVZxUDVVZkJ0WEFs?= =?utf-8?B?cXl5R0gzdWpIUXA2ZWU3RGI1Y1ZBdkUzTDB0a3YzbTk3bjV0M3F1b2d3dE1N?= =?utf-8?B?NzVycC9GK25lVXRQRVJENkUrSkZFYndvMjhSMXRMdE1wR0E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;6:0oqbqG/TOR4CjGXFFQJeNhxR+mJx7aUEbcbrao+DjRbG41up6gDp0180MZUMgKdP1P0SLH4kBuRmfCZponrA/stzbC3W70uj28pSuiWvVgZUW2DDjB8j0BJdE2vMz+ijhIes4l78rKOL/7sRLqZdaLvtl41iINjqe7FBZaxVq99Wjr3AgwiflIb9Y++EJMAO6ELd6kBjRV+k4uI6VqVbxtYoqCmpIvb/+YEjA95NFPIE5EjIi1pzYkBs02gp7p+gYBlitEx8YURNMYxBfwKKlwYJ+zH+y52Y4pGzoLhZnZZkTL4W1hR2C0yKAQ1XZTV+TcNtb4e7WHiqgW+i914y5cLShOz7cIFBIZ0QKlEd7ZcQn1abJZHZ2xulEblGqELAHA+FFzTLXLvsIRHZNi8SrzpWwVAFYKNzO3sRSLm4vWQo8Kt+ICnR1H50xSd5U5Z6rsFSuyEweNBqGSwmgwD4yNx0WDT059okVgIk871siVtrnAO8K4yoSB/grFj7lNtr7Rzd21DWLPjyi1GIsp6dUrbG5IIhrLfnoU2LVCeKmgo=;5:/+7EniL6K3QgmhlbTwIuVnzHTCsp8RUolrZvyhIV0JeG6K536suf9CmZO1QVqbGTB7bDvLmFchXLDrlx8bNzxrAQAZYRhzwbB68dFKW63+HeG0p86D/cdDr7Uj1zcGBB9TTK1upJ1mhBNeXJjUKs3TAE9+PEeVVa2+2mGbntJOI=;24:Azf9DdgInOPgVHo+FnyWmY6r4MCOwN7B31ivmFkpZjKgZJxHz0ikq9XDVHyFwC2njtMFf2zId7pp5uv0/CO85l4ANHBNYxCMuNJI8Om9Jj4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1141;7:mCx0Wsl46SUd+Tuzn1CKEXK+7RFMJIVkL/Re7adkICdsDMLsTdQ+rUkw7W5Tm2fBaoBy0N/0kaJuzgFgNXIT/2xvns9S+NtLsAMF/1uL5PZc+0He7THVAwprNfrzsCczRXP8fcWK3e7R2Nn5S9b3pu78rlmPrzblevglD0QK++aSEOD942AEo3z4XczCthFYervRO9KeLrVzvnUxRtHub8gvUmMgZJgZaYHihFgqMF5l/IDzofwYF4tj/gwHB7ORh/e6pEZmxGuPjMELVSdv3OO64g1CoivyZD16jVHlcNkwTvTx9m+18KMAgCombze6G9BR58saQpc2sgDh5cNm/w==;20:AN1cAjl3CotsQR+Qh7ADe7WU59CY2evVVq8CdO1G0ZIQ6rlGbdLqOiBVIcMJ4pejP0lce2CtY+XxbtGh1G4tKynmq6vy1LIIZA8ZoCVocY/8IgAHDYHOftWiqhIhaBXsXCSk2Id0NPBjsA7vRtUqaImk2wbrNrseatoL5d8LV5lPLnYMgpML8e9lAuZXB7UHFgAvAZVyhRF80NIaMpCApeAv2SBH0H7Le5DcxyWrMDlEzvAnkh8/PrmSW0q7BFxx X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2017 15:48:36.5486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2017 3:16 PM, Josh Poimboeuf wrote: > On Fri, May 19, 2017 at 01:30:05PM +0200, Borislav Petkov wrote: >>> it is called so early. I can get past it by adding: >>> >>> CFLAGS_mem_encrypt.o := $(nostackp) >>> >>> in the arch/x86/mm/Makefile, but that obviously eliminates the support >>> for the whole file. Would it be better to split out the sme_enable() >>> and other boot routines into a separate file or just apply the >>> $(nostackp) to the whole file? >> >> Josh might have a better idea here... CCed. > > I'm the stack validation guy, not the stack protection guy :-) > > But there is a way to disable compiler options on a per-function basis > with the gcc __optimize__ function attribute. For example: > > __attribute__((__optimize__("no-stack-protector"))) > I'll look at doing that instead of removing the support for the whole file. Thanks, Tom