From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbbEUXYP (ORCPT ); Thu, 21 May 2015 19:24:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55082 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbbEUXYK (ORCPT ); Thu, 21 May 2015 19:24:10 -0400 Message-ID: <1ae9ad74d48d03a477ae6ffca028a5d3.squirrel@www.codeaurora.org> In-Reply-To: <555E3466.4050403@codeaurora.org> References: <1431985887-23379-1-git-send-email-ankgupta@codeaurora.org> <555E3466.4050403@codeaurora.org> Date: Thu, 21 May 2015 17:24:09 -0600 Subject: Re: [PATCH] spmi: add command tracepoints for SPMI From: "Ankit Gupta" To: "Stephen Boyd" Cc: "Ankit Gupta" , gavidov@codeaurora.org, sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, ivan.ivanov@linaro.org, linux-kernel@vger.kernel.org, svarbanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 05/18/15 14:51, Ankit Gupta wrote: >> Add tracepoints to retrieve information about read, write >> and non-data commands. For performance measurement support >> tracepoints are added at the beginning and at the end of >> transfers. Following is a list showing the new tracepoint >> events. The "cmd" parameter here represents the opcode, SID, >> and full 16-bit address. >> >> spmi_write_begin: cmd and data buffer. >> spmi_write_end : cmd and return value. >> spmi_read_begin : cmd. >> spmi_read_end : cmd, return value and data buffer. >> spmi_cmd : cmd. >> >> The reason that cmd appears at both the beginning and at >> the end event is that SPMI drivers can request commands >> concurrently. cmd helps in matching the corresponding >> events. >> >> SPMI tracepoints can be enabled like: >> >> echo 1 >/sys/kernel/debug/tracing/events/spmi/enable >> >> and will dump messages that can be viewed in >> /sys/kernel/debug/tracing/trace that look like: >> >> ... spmi_read_begin: opc=56 sid=00 addr=0x0000 >> ... spmi_read_end: opc=56 sid=00 addr=0x0000 ret=0 len=02 buf=0x[01-40] >> ... spmi_write_begin: opc=48 sid=00 addr=0x0000 len=3 buf=0x[ff-ff-ff] >> >> Signed-off-by: Ankit Gupta >> Signed-off-by: Gilad Avidov >> Suggested-by: Sagar Dharia >> --- > > Assuming you fix sign-off-chain: > > Reviewed-by: Stephen Boyd Sorry, Missed your this email, will upload a new patch with just change of sign-off order. Thanks > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > >