From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752131AbdC0G0m (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Mar 2017 02:26:42 -0400
Received: from mout.web.de ([212.227.15.3]:53905 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752095AbdC0G0a (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Mar 2017 02:26:30 -0400
Subject: Re: selinux: Delete unnecessary variable assignments in
 policydb_index()
To: Paul Moore <paul@paul-moore.com>
References: <ca34123f-ced6-d2bc-363b-690858618827@users.sourceforge.net>
 <247c0e27-c442-3408-4f92-492629d61fbf@users.sourceforge.net>
 <CAHC9VhRHEDCRNVfOqw4mwJQD9PmESEcgyZ7xCEwHZKpiDSjnYw@mail.gmail.com>
Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
        Eric Paris <eparis@parisplace.org>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Stephen Smalley <sds@tycho.nsa.gov>,
        William Roberts <william.c.roberts@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Casey Schaufler <casey@schaufler-ca.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <1ae9af46-a3ca-33b8-d347-8983a22cb3cb@users.sourceforge.net>
Date: Mon, 27 Mar 2017 08:24:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAHC9VhRHEDCRNVfOqw4mwJQD9PmESEcgyZ7xCEwHZKpiDSjnYw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:Bz2BjttrFUx6EuF+nn+dBRPofaRu94425z/f50ZOMa6lXdV9h7Y
 g6XpMuc+Ouwk9N9dW1T3LtOOeVO3YjBFC4NG56Pcbue+iT7DEi17GwQyI0Q6vtwV7Cgxffe
 dScLtUA1C9JsC+6mSNYCl/HAHasNZ2aIGUWplJeUUJ8FzpHRdkR3YX2m4XUk9H4bjcb0jiu
 Kx+2fJqMiMOfjJZUZHuSA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:lXGmUTd9jcY=:IvTApmKgI/6N78NAcdWoxE
 mK5m1tqqGFt9dFoyOiTJk3sB6+1bVAS0Z5kR1rKh5OSpc++gFxJD2e3EE4nilonT71fqdszUP
 KZI1XHxQHFLgle8thFMRBgUGxnxe6GQl8NslRJV3+c5OElicxzgCnZJw2vAh7nciUIoUVv9re
 TPYaDaCBlq2f5awMkkiAeJXeuL4HL1ws1DQ1od32cPvlLSn4m3dK7Jt1UmE4TVovMONoiUzvc
 U+y0ePVpglX4yLWXFSZ9ZnqCjAafrBHQPtXPdmbIoEXl+Q1KxYuJFUqztalAd16TNnxlV7kbS
 WB75/uwM6VIFua9dKd3YukJn79bebOHydV/U0pxqVQrQ2+o/rhoDHsM40uQ/W3z7GU+Vs/Tuz
 CApbD7WPLIvuuNr6gseRajs9sdMR5xR4Vjegadgdyobgf93m/gdGMTJBIPKRT84OpbK2QZTvQ
 OQmcHATMEJyGrXfIyRkvzLoa8wzIhi1rdb4vHX6j0SVlDtYEOTukdsX7PDjl7JzGDZZQxImCK
 51PD9PtjWfOxwyWJ/PI/CndxA6AHTdk0bobRNMcx9f4ihmocK5yNkgdYcCyt/fqxTwMk45vMF
 Keybq2zFdVb/tEf9+WH9q4jta1Ud6QADE8rkUEP++2YBO8YeJKt3aKNBSwP2CfxRcPDgCx3EK
 6YIYz8rpnpOPIcNkashn0laI9xtfBBmVCXURB5a5KA6gxkRqOIaIdBxynJcAuHCl1WrS1g2Gh
 hjluFCS1ybgJuLLcV9TaW41/rBkLNJegD9WDuZ+0iD1vt5hBasUqD7k+MxWQxfzHDSbLf38/s
 nPOWZ9/
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> However, I agree with Casey that this patch is mostly just code churn
> so I'm going to drop this from your series.

How do you think about to return only constant error codes in this function?
Would it be acceptable to replace any statements “goto out;” with
“return -ENOMEM;” here instead?

Regards,
Markus