From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH v3 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards
Date: Fri, 16 Jul 2021 12:00:53 +0200 [thread overview]
Message-ID: <1af8d8ecd5beacb9d202494acea8fea2e350bc45.1626429286.git.matthias.schiffer@ew.tq-group.com> (raw)
In-Reply-To: <cover.1626429286.git.matthias.schiffer@ew.tq-group.com>
In-Reply-To: <cover.1626429286.git.matthias.schiffer@ew.tq-group.com>
All future TQMx86 modules should use a 24MHz LPC clock. Warn about
unknown boards, but assume this is the case.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v2:
- Separated from TQMxE40M support patch
- Add warning for unknown boards
v3: no changes
drivers/mfd/tqmx86.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index 58f35c8b5a45..7ae906ff8e35 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -147,7 +147,7 @@ static const char *tqmx86_board_id_to_name(u8 board_id)
}
}
-static int tqmx86_board_id_to_clk_rate(u8 board_id)
+static int tqmx86_board_id_to_clk_rate(struct device *dev, u8 board_id)
{
switch (board_id) {
case TQMX86_REG_BOARD_ID_50UC:
@@ -168,7 +168,9 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id)
case TQMX86_REG_BOARD_ID_E38C:
return 33000;
default:
- return 0;
+ dev_warn(dev, "unknown board %d, assuming 24MHz LPC clock\n",
+ board_id);
+ return 24000;
}
}
@@ -229,7 +231,7 @@ static int tqmx86_probe(struct platform_device *pdev)
tqmx_gpio_resources[0].flags = 0;
}
- ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id);
+ ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(dev, board_id);
if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) {
err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
--
2.17.1
next prev parent reply other threads:[~2021-07-16 10:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 10:00 [PATCH v3 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Matthias Schiffer
2021-07-16 10:00 ` [PATCH v3 1/7] gpio: tqmx86: really make IRQ optional Matthias Schiffer
2021-07-23 16:15 ` Linus Walleij
2021-08-02 15:18 ` Bartosz Golaszewski
2021-07-16 10:00 ` [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-08-05 13:30 ` Lee Jones
2021-08-05 13:40 ` Matthias Schiffer
2021-08-05 13:42 ` Andy Shevchenko
2021-08-09 7:11 ` Matthias Schiffer
2021-07-16 10:00 ` [PATCH v3 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Matthias Schiffer
2021-08-05 13:31 ` Lee Jones
2021-07-16 10:00 ` [PATCH v3 4/7] mfd: tqmx86: fix typo in "platform" Matthias Schiffer
2021-08-05 13:38 ` Lee Jones
2021-07-16 10:00 ` [PATCH v3 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Matthias Schiffer
2021-07-16 10:00 ` [PATCH v3 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Matthias Schiffer
2021-07-16 10:00 ` Matthias Schiffer [this message]
2021-08-16 13:02 ` [PATCH v3 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af8d8ecd5beacb9d202494acea8fea2e350bc45.1626429286.git.matthias.schiffer@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).