From: Florian Fainelli <f.fainelli@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
YueHaibing <yuehaibing@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mdio_bus: Fix init if CONFIG_RESET_CONTROLLER=n
Date: Tue, 19 Nov 2019 10:05:13 -0800 [thread overview]
Message-ID: <1afede33-897b-8718-d977-351357dffe4f@gmail.com> (raw)
In-Reply-To: <20191119112524.24841-1-geert+renesas@glider.be>
On 11/19/19 3:25 AM, Geert Uytterhoeven wrote:
> Commit 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after
> initialization to constant") accidentally changed a check from -ENOTSUPP
> to -ENOSYS, causing failures if reset controller support is not enabled.
> E.g. on r7s72100/rskrza1:
>
> sh-eth e8203000.ethernet: MDIO init failed: -524
> sh-eth: probe of e8203000.ethernet failed with error -524
>
> Fixes: 1d4639567d970de0 ("mdio_bus: Fix PTR_ERR applied after initialization to constant")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This has been fixed in the "net" tree with:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=075e238d12c21c8bde700d21fb48be7a3aa80194
--
Florian
next prev parent reply other threads:[~2019-11-19 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:25 [PATCH] mdio_bus: Fix init if CONFIG_RESET_CONTROLLER=n Geert Uytterhoeven
2019-11-19 18:05 ` Florian Fainelli [this message]
2019-11-19 18:55 ` Geert Uytterhoeven
2019-11-20 3:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afede33-897b-8718-d977-351357dffe4f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).