From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 603B2C38A2D for ; Mon, 24 Oct 2022 08:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbiJXI7k convert rfc822-to-8bit (ORCPT ); Mon, 24 Oct 2022 04:59:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiJXI7i (ORCPT ); Mon, 24 Oct 2022 04:59:38 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDB625FE for ; Mon, 24 Oct 2022 01:59:35 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-117-I8N-gZ2NNC-WTLUcJNiHWw-1; Mon, 24 Oct 2022 09:59:31 +0100 X-MC-Unique: I8N-gZ2NNC-WTLUcJNiHWw-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 24 Oct 2022 09:59:29 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.042; Mon, 24 Oct 2022 09:59:29 +0100 From: David Laight To: 'Greg Kroah-Hartman' , Sakari Ailus CC: "linux-kernel@vger.kernel.org" , "Andy Shevchenko" , "Rafael J. Wysocki" Subject: RE: [PATCH 1/1] linux/container_of.h: Warn about loss of constness Thread-Topic: [PATCH 1/1] linux/container_of.h: Warn about loss of constness Thread-Index: AQHY54TCH4qdMwC1Yk+S6+0KOnujn64dPf3A Date: Mon, 24 Oct 2022 08:59:29 +0000 Message-ID: <1b02ad7256564b5ca8a43df60f8d7a45@AcuMS.aculab.com> References: <20221024082610.74990-1-sakari.ailus@linux.intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman > Sent: 24 October 2022 09:44 ... > > + * WARNING: as container_of() casts the given struct to another, also the > > No need for "also" here (sorry for the grammar nit.) > > > + * possible const qualifier of @ptr is lost unless it is also specified in > > + * @type. This is not a problem if the containing object is not const. Use with > > + * care. > > I do not think these last two sentences you added here are needed > either. It is all TL;DR :-) Even just: NOTE: any const qualifier of @ptr is lost. Is probably more than enough. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)