From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbcFFPTT (ORCPT ); Mon, 6 Jun 2016 11:19:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:40500 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbcFFPTR (ORCPT ); Mon, 6 Jun 2016 11:19:17 -0400 Subject: Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock To: Joonsoo Kim References: <1464230275-25791-1-git-send-email-iamjoonsoo.kim@lge.com> Cc: Andrew Morton , Mel Gorman , Minchan Kim , Alexander Potapenko , Hugh Dickins , Michal Hocko , LKML , Linux Memory Management List , Joonsoo Kim From: Vlastimil Babka Message-ID: <1b0e617e-3853-4c8c-2c75-b1d95bfd6ded@suse.cz> Date: Mon, 6 Jun 2016 17:19:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2016 02:45 PM, Joonsoo Kim wrote: > 2016-06-03 19:10 GMT+09:00 Vlastimil Babka : >> On 05/26/2016 04:37 AM, js1304@gmail.com wrote: >>> >>> From: Joonsoo Kim >>> >>> We don't need to split freepages with holding the zone lock. It will cause >>> more contention on zone lock so not desirable. >>> >>> Signed-off-by: Joonsoo Kim >> >> >> So it wasn't possible to at least move this code from compaction.c to >> page_alloc.c? Or better, reuse prep_new_page() with some forged >> gfp/alloc_flags? As we discussed in v1... > > Sorry for not mentioning that I did it as a separate patch, > Please see below link which is the last one within this patchset. > > Link: http://lkml.kernel.org/r/1464230275-25791-7-git-send-email-iamjoonsoo.kim@lge.com Ah I see. In that case, Acked-by: Vlastimil Babka > Thanks. >