From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ryan Lee <ryans.lee@maximintegrated.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, yung-chuan.liao@linux.intel.com,
guennadi.liakhovetski@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: sathya.prakash.m.r@intel.com, ryan.lee.maxim@gmail.com
Subject: Re: [PATCH] ASoC: max98373: Mark cache dirty before entering sleep
Date: Mon, 27 Sep 2021 09:54:42 -0500 [thread overview]
Message-ID: <1b21bbf1-12c7-726d-bff8-76ec88ff8635@linux.intel.com> (raw)
In-Reply-To: <20210924221305.17886-1-ryans.lee@maximintegrated.com>
On 9/24/21 5:13 PM, Ryan Lee wrote:
> Amp lose its register values in case amp power loss or
> 'ForceReset' over Soundwire SCP_ctrl register(0x0044) or
> HW_RESET pin control during the audio suspend and resume.
> Mark cache dirty before audio suspension to restore
> existing values when audio resume.
>
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> sound/soc/codecs/max98373-sdw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c
> index dc520effc61c..a7e4a6e880b0 100644
> --- a/sound/soc/codecs/max98373-sdw.c
> +++ b/sound/soc/codecs/max98373-sdw.c
> @@ -259,6 +259,7 @@ static __maybe_unused int max98373_suspend(struct device *dev)
> regmap_read(max98373->regmap, max98373->cache[i].reg, &max98373->cache[i].val);
>
> regcache_cache_only(max98373->regmap, true);
> + regcache_mark_dirty(max98373->regmap);
We already do the following sequence in max98373_io_init() when the
amplifier re-attaches:
if (max98373->first_hw_init) {
regcache_cache_bypass(max98373->regmap, false);
regcache_mark_dirty(max98373->regmap);
}
I don't see what marking the cache as dirty on suspend might do, we will
do a sync only in the resume step.
IIRC this is a patch that we've seen before and removed since it wasn't
aligned with any other codec driver.
Does this actually improve anything?
next prev parent reply other threads:[~2021-09-27 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 22:13 [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Ryan Lee
2021-09-27 14:54 ` Pierre-Louis Bossart [this message]
2021-09-27 16:01 ` [EXTERNAL] " Ryan Lee
2021-09-27 16:06 ` Mark Brown
2021-09-27 16:48 ` Pierre-Louis Bossart
2021-09-27 17:10 ` Mark Brown
2021-09-27 17:23 ` Pierre-Louis Bossart
2021-09-27 17:29 ` Mark Brown
2021-09-28 16:43 ` Ryan Lee
2021-09-28 18:15 ` Pierre-Louis Bossart
2021-09-27 18:44 ` Ryan Lee
2021-09-27 19:34 ` Pierre-Louis Bossart
2021-09-27 22:43 ` Ryan Lee
2021-09-30 6:21 ` Ryan Lee
2021-09-30 13:29 ` Pierre-Louis Bossart
2021-09-30 23:31 ` Ryan Lee
2021-09-30 23:53 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b21bbf1-12c7-726d-bff8-76ec88ff8635@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).