From: James Bottomley <jejb@linux.ibm.com>
To: Zhong Jinghua <zhongjinghua@huawei.com>,
gregkh@linuxfoundation.org, martin.petersen@oracle.com,
hare@suse.de, bvanassche@acm.org, emilne@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
yi.zhang@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH-next v2 2/2] scsi: fix iscsi rescan fails to create block device
Date: Sun, 29 Jan 2023 12:30:30 -0500 [thread overview]
Message-ID: <1b466057ed2e91b05388afbb5791639eb8abdd59.camel@linux.ibm.com> (raw)
In-Reply-To: <20230128094146.205858-3-zhongjinghua@huawei.com>
On Sat, 2023-01-28 at 17:41 +0800, Zhong Jinghua wrote:
> This error will cause a warning:
> kobject_add_internal failed for block (error: -2 parent: 1:0:0:1).
> In the lower version (such as 5.10), there is no corresponding error
> handling, continuing
> to go down will trigger a kernel panic, so cc stable.
Is this is important point and what you're saying is that this only
panics on kernels before 5.10 or so because after that it's correctly
failed by block device error handling so there's nothing to fix in
later kernels?
In that case, isn't the correct fix to look at backporting the block
device error handling:
commit 83cbce9574462c6b4eed6797bdaf18fae6859ab3
Author: Luis Chamberlain <mcgrof@kernel.org>
Date: Wed Aug 18 16:45:40 2021 +0200
block: add error handling for device_add_disk / add_disk
?
James
next prev parent reply other threads:[~2023-01-29 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 9:41 [PATCH-next v2 0/2] scsi, driver core: fix iscsi rescan fails to create block device Zhong Jinghua
2023-01-28 9:41 ` [PATCH-next v2 1/2] driver core: introduce get_device_unless_zero() Zhong Jinghua
2023-01-28 10:43 ` Greg KH
2023-01-28 9:41 ` [PATCH-next v2 2/2] scsi: fix iscsi rescan fails to create block device Zhong Jinghua
2023-01-28 10:45 ` Greg KH
2023-01-29 1:13 ` Yu Kuai
2023-01-29 6:46 ` Greg KH
2023-01-29 6:55 ` Yu Kuai
2023-01-29 17:30 ` James Bottomley [this message]
2023-01-30 3:07 ` Yu Kuai
2023-01-30 3:29 ` James Bottomley
2023-01-30 3:46 ` Yu Kuai
2023-01-30 13:17 ` James Bottomley
2023-01-31 1:43 ` Yu Kuai
2023-01-31 3:25 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b466057ed2e91b05388afbb5791639eb8abdd59.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhongjinghua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).