From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <jim2101024@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com
Cc: Jim Quinlan <jquinlan@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v3 1/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
Date: Wed, 16 Dec 2020 13:59:56 -0800 [thread overview]
Message-ID: <1b66cceb-577f-658f-9a97-ec987c87367a@gmail.com> (raw)
In-Reply-To: <20201216214106.32851-2-james.quinlan@broadcom.com>
On 12/16/20 1:41 PM, Jim Quinlan wrote:
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> This driver may use one of two resets controllers. Keep them in separate
> variables to keep things simple. The reset controller "rescal" is shared
> between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. Use
> devm_reset_control_get_optional_shared() to handle this sharing.
>
> Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting")
> Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller name")
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
Thanks a lot for fixing this Jim, given the reset lines are still
mutually exclusive the single variable along with the 7216 versus
another chip differentiation would still work, but I have no objection
to the approach you have taken:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-12-16 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 21:41 [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller Jim Quinlan
2020-12-16 21:41 ` [RESEND PATCH v3 1/2] " Jim Quinlan
2020-12-16 21:59 ` Florian Fainelli [this message]
2020-12-16 21:41 ` [RESEND PATCH v3 2/2] PCI: brcmstb: use reset/rearm instead of deassert/assert Jim Quinlan
2020-12-16 22:02 ` Florian Fainelli
2020-12-24 0:05 ` [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller Florian Fainelli
2021-01-05 21:22 ` Florian Fainelli
2021-01-14 20:46 ` Florian Fainelli
2021-01-21 20:48 ` Florian Fainelli
2021-01-22 0:20 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b66cceb-577f-658f-9a97-ec987c87367a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=jquinlan@broadcom.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).