From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751027AbcJJIuR (ORCPT ); Mon, 10 Oct 2016 04:50:17 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36063 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbcJJIuN (ORCPT ); Mon, 10 Oct 2016 04:50:13 -0400 Subject: Re: [PATCH 10/10] net: mdio-sam: Add device tree documentation for SAM MDIO To: Pantelis Antoniou , Lee Jones References: <1475853518-22264-1-git-send-email-pantelis.antoniou@konsulko.com> <1475853518-22264-11-git-send-email-pantelis.antoniou@konsulko.com> Cc: Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , Frank Rowand , Wolfram Sang , David Woodhouse , Brian Norris , Wim Van Sebroeck , Peter Rosin , Debjit Ghosh , Georgi Vlaev , Guenter Roeck , Maryam Seraj , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-watchdog@vger.kernel.org, netdev@vger.kernel.org From: Florian Fainelli Message-ID: <1b764238-1094-dcbc-1176-fdc845781c31@gmail.com> Date: Mon, 10 Oct 2016 01:50:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475853518-22264-11-git-send-email-pantelis.antoniou@konsulko.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2016 08:18 AM, Pantelis Antoniou wrote: > From: Georgi Vlaev > > Add device tree bindings document for the SAM MDIO block > present in Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou > --- > Documentation/devicetree/bindings/net/mdio-sam.txt | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/mdio-sam.txt > > diff --git a/Documentation/devicetree/bindings/net/mdio-sam.txt b/Documentation/devicetree/bindings/net/mdio-sam.txt > new file mode 100644 > index 0000000..7d354e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mdio-sam.txt > @@ -0,0 +1,48 @@ > +Juniper SAM FPGA MFD MDIO bus properties. > + > +Required properties: > +- compatible : "jnx,mdio-sam" > +- reg : The start offset of the MDIO bus range > +- #address-cells = <1>; > +- #size-cells = <0>; > + > +Optional properties: > + > +Required properties for child nodes: > +- #address-cells = <1>; > +- #size-cells = <0>; > +- reg : The MDIO bus offset within the MDIO range. I would just refer to Documentation/devicetree/bindings/net/phy.txt for the child node properties. Other than that: Reviewed-by: Florian Fainelli -- Florian