From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbdLIRrO (ORCPT ); Sat, 9 Dec 2017 12:47:14 -0500 Received: from mx1.yrkesakademin.fi ([85.134.45.194]:48779 "EHLO mx1.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdLIRrN (ORCPT ); Sat, 9 Dec 2017 12:47:13 -0500 X-Greylist: delayed 907 seconds by postgrey-1.27 at vger.kernel.org; Sat, 09 Dec 2017 12:47:13 EST Subject: Re: [PATCH 4.14 00/75] 4.14.5-stable review To: Greg Kroah-Hartman , Ivan Kozik CC: , Linus Torvalds , , Guenter Roeck , Shuah Khan , , Ben Hutchings , , References: <20171207130818.742746317@linuxfoundation.org> <20171209074544.GA1770@kroah.com> <20171209171349.GA26021@kroah.com> From: Thomas Backlund Message-ID: <1b8f1c5e-f616-0e10-2ce2-8bd07e4260d8@mageia.org> Date: Sat, 9 Dec 2017 19:32:38 +0200 MIME-Version: 1.0 In-Reply-To: <20171209171349.GA26021@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-WatchGuard-Spam-ID: str=0001.0A0C0203.5A2C21A1.0077,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-WatchGuard-Spam-Score: 0, clean; 0, virus threat unknown X-WatchGuard-Mail-Client-IP: 85.134.45.194 X-WatchGuard-Mail-From: tmb@mageia.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 09.12.2017 kl. 19:13, skrev Greg Kroah-Hartman: > On Sat, Dec 09, 2017 at 07:56:40AM +0000, Ivan Kozik wrote: >> On Sat, Dec 9, 2017 at 7:45 AM, Greg Kroah-Hartman >> wrote: >>> On Sat, Dec 09, 2017 at 03:34:24AM +0000, Ivan Kozik wrote: >>>> I saw no problems on 8 of 9 machines, but the last one had a problem >>>> because it used NVIDIA drivers (387); DKMS reported: >>>> >>>> FATAL: modpost: GPL-incompatible module nvidia-drm.ko uses GPL-only >>>> symbol 'ex_handler_refcount' >>>> //usr/src/linux-headers-4.14.0-11-common/scripts/Makefile.modpost:92: >>>> recipe for target '__modpost' failed >>>> make[3]: *** [__modpost] Error 1 >>> >>> Is this a new issue? Does 4.14.4 have this issue? >> >> I believe it is a new issue, because I have a 4.14.4 build and an >> NVIDIA DKMS log for that 4.14.4 showing build success. >> >>> Odd, is 564c9cc84e2a ("locking/refcounts, x86/asm: Use unique .text >>> section for refcount exceptions") causing this? >> >> That was my guess too, but I did not verify. > > That feels really wrong here, I'd like to get some confirmation before I > add this patch... > It's needed. The reason you hit in 4.14.5 queue is because of: [PATCH 4.14 64/75] locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT From foo@baz Wed Dec 6 18:04:41 CET 2017 From: Kees Cook Date: Sat, 2 Sep 2017 13:09:46 -0700 Subject: locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT that does this: - select ARCH_HAS_REFCOUNT if BROKEN + select ARCH_HAS_REFCOUNT So it exposes previously hidden code.... -- Thomas