From: Jonas Bonn <jonas@norrbonn.se>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Baolin Wang <baolin.wang@linaro.org>,
lanqing.liu@spreadtrum.com
Subject: Re: [PATCH v3 1/2] spi: support inter-word delay requirement for devices
Date: Mon, 28 Jan 2019 22:28:14 +0100 [thread overview]
Message-ID: <1b9807aa-3e6e-16f2-a2c2-ebe5e186d904@norrbonn.se> (raw)
In-Reply-To: <20190128181038.GF11699@sirena.org.uk>
Hi,
On 28/01/2019 19:10, Mark Brown wrote:
> On Sat, Jan 26, 2019 at 05:32:19PM +0100, Jonas Bonn wrote:
>
>> @@ -164,6 +166,7 @@ struct spi_device {
>> char modalias[SPI_NAME_SIZE];
>> const char *driver_override;
>> int cs_gpio; /* chip select gpio */
>> + uint16_t word_delay; /* inter-word delay (us) */
>
> This needs some code in the core joining it up with the per-transfer
> word delay similar to what we have for speed_hz and bits_per_word in
> __spi_validate(). Then the controller drivers can just look at the
> per-transfer value and support both without having to duplicate logic.
>
So spi_transfer already has a field word_delay and it's defined as
_clock cycles_ to delay between words. I defined word_delay in
spi_device as _microseconds_ to delay along the lines of delay_usecs.
Given that the inter-word delay is a function of the slave device speed
and not of the SPI bus speed, I'm inclined to say that a time-based
delay is what we want (to be independent of bus speed). As such, I want
to know if I should add word_delay_usecs to _both_ spi_transfer and
spi_device?
There's only one user of word_delay from spi_transfer. Just looking at
it quickly, it looks like it wants the word_delay in
SPI-controller-clock cycles and not SCK cycles which seems pretty broken
to me. Adding Baolin and Lanqing to CC: for comment. Could we rework
that to be microseconds and do the calculation in the driver?
Thanks,
Jonas
next prev parent reply other threads:[~2019-01-28 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 16:32 [PATCH v3 0/2] spi: support inter-word delays Jonas Bonn
2019-01-26 16:32 ` [PATCH v3 1/2] spi: support inter-word delay requirement for devices Jonas Bonn
2019-01-28 18:10 ` Mark Brown
2019-01-28 21:28 ` Jonas Bonn [this message]
2019-01-29 9:04 ` Baolin Wang
2019-01-29 9:14 ` Jonas Bonn
2019-01-29 9:35 ` Baolin Wang
2019-01-29 9:49 ` Jonas Bonn
2019-01-29 10:07 ` Geert Uytterhoeven
2019-01-29 16:41 ` Mark Brown
2019-01-26 16:32 ` [PATCH v3 2/2] spi-atmel: support inter-word delay Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9807aa-3e6e-16f2-a2c2-ebe5e186d904@norrbonn.se \
--to=jonas@norrbonn.se \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=lanqing.liu@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).