From: Akash Asthana <akashast@codeaurora.org>
To: Douglas Anderson <dianders@chromium.org>,
Mark Brown <broonie@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, mkshah@codeaurora.org,
swboyd@chromium.org, georgi.djakov@linaro.org,
ctheegal@codeaurora.org, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed
Date: Tue, 7 Jul 2020 15:46:22 +0530 [thread overview]
Message-ID: <1b9f0313-0e8f-0a75-b0a5-b6a768af0a7a@codeaurora.org> (raw)
In-Reply-To: <20200701174506.1.Icfdcee14649fc0a6c38e87477b28523d4e60bab3@changeid>
On 7/2/2020 6:15 AM, Douglas Anderson wrote:
> Every SPI transfer could have a different clock rate. The
> spi-geni-qcom controller code to deal with this was never very well
> optimized and has always had a lot of code plus some calls into the
> clk framework which, at the very least, would grab a mutex. However,
> until recently, the overhead wasn't _too_ much. That changed with
> commit 0e3b8a81f5df ("spi: spi-geni-qcom: Add interconnect support")
> we're now calling geni_icc_set_bw(), which leads to a bunch of math
> plus:
> geni_icc_set_bw()
> icc_set_bw()
> apply_constraints()
> qcom_icc_set()
> qcom_icc_bcm_voter_commit()
> rpmh_invalidate()
> rpmh_write_batch()
> ...and those rpmh commands can be a bit beefy if you call them too
> often.
Reviewed-by: Akash Asthana<akashast@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-07-07 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 0:45 [PATCH 0/3] spi: spi-geni-qcom: Avoid a bunch of per-transfer overhead Douglas Anderson
2020-07-02 0:45 ` [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed Douglas Anderson
2020-07-07 10:16 ` Akash Asthana [this message]
2020-07-07 12:08 ` Mark Brown
2020-07-07 12:53 ` Doug Anderson
2020-07-08 10:01 ` Mark Brown
2020-07-08 15:22 ` Doug Anderson
2020-07-08 17:02 ` Mark Brown
2020-07-08 12:48 ` Mark Brown
2020-07-02 0:45 ` [PATCH 2/3] spi: spi-geni-qcom: Set an autosuspend delay of 250 ms Douglas Anderson
2020-07-07 10:18 ` Akash Asthana
2020-07-02 0:45 ` [PATCH 3/3] spi: spi-geni-qcom: Get rid of most overhead in prepare_message() Douglas Anderson
2020-07-07 13:37 ` Akash Asthana
2020-07-08 12:49 ` Mark Brown
2020-07-07 14:17 ` [PATCH 0/3] spi: spi-geni-qcom: Avoid a bunch of per-transfer overhead Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9f0313-0e8f-0a75-b0a5-b6a768af0a7a@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=ctheegal@codeaurora.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).