From: <Codrin.Ciubotariu@microchip.com>
To: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <Nicolas.Ferre@microchip.com>, <Claudiu.Beznea@microchip.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <andrew@lunn.ch>,
<robh+dt@kernel.org>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node
Date: Thu, 23 Jul 2020 22:08:51 +0000 [thread overview]
Message-ID: <1ba55a2a-487a-dbd5-29e6-5d4231e80167@microchip.com> (raw)
In-Reply-To: <460e5f3d-f3a0-154e-d617-d1536c96e390@gmail.com>
On 23.07.2020 21:59, Florian Fainelli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 7/21/20 10:13 AM, Codrin Ciubotariu wrote:
>> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes
>> were represented as sub-nodes in the MACB node. Generally, the
>> Ethernet controller is different than the MDIO controller, so the PHYs
>> are probed by a separate MDIO driver. Since adding the PHY nodes directly
>> under the ETH node became deprecated, we adjust the MACB driver to look
>> for an MDIO node and register the subnode MDIO devices.
>>
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>> ---
>>
>> Changes in v2:
>> - readded newline removed by mistake;
>>
>> drivers/net/ethernet/cadence/macb_main.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> index 89fe7af5e408..b25c64b45148 100644
>> --- a/drivers/net/ethernet/cadence/macb_main.c
>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> @@ -740,10 +740,20 @@ static int macb_mii_probe(struct net_device *dev)
>> static int macb_mdiobus_register(struct macb *bp)
>> {
>> struct device_node *child, *np = bp->pdev->dev.of_node;
>> + struct device_node *mdio_node;
>> + int ret;
>>
>> if (of_phy_is_fixed_link(np))
>> return mdiobus_register(bp->mii_bus);
>
> Does not this need changing as well? Consider the use case of having
> your MACB Ethernet node have a fixed-link property to describe how it
> connects to a switch, and your MACB MDIO controller, expressed as a
> sub-node, describing the MDIO attached switch it connects to.
Right, this is what I was discussing with Claudiu on the other thread. I
am thinking to just move the look for mdio before checking for
fixed-link. This will probe the MDIO devices and simple mdiobus_register
will be called only if the mdio node is missing.
Thank you for your review(s)!
Best regards,
Codrin
>
>>
>> + /* if an MDIO node is present, it should contain the PHY nodes */
>> + mdio_node = of_get_child_by_name(np, "mdio");
>> + if (mdio_node) {
>> + ret = of_mdiobus_register(bp->mii_bus, mdio_node);
>> + of_node_put(mdio_node);
>> + return ret;
>> + }
>> +
>> /* Only create the PHY from the device tree if at least one PHY is
>> * described. Otherwise scan the entire MDIO bus. We do this to support
>> * old device tree that did not follow the best practices and did not
>>
>
>
> --
> Florian
>
next prev parent reply other threads:[~2020-07-23 22:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 17:13 [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Codrin Ciubotariu
2020-07-21 17:13 ` [PATCH net-next v2 1/7] net: macb: use device-managed devm_mdiobus_alloc() Codrin Ciubotariu
2020-07-23 18:55 ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 2/7] dt-bindings: net: macb: use an MDIO node as a container for PHY nodes Codrin Ciubotariu
2020-07-23 17:51 ` Rob Herring
2020-07-23 18:56 ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node Codrin Ciubotariu
2020-07-23 18:59 ` Florian Fainelli
2020-07-23 22:08 ` Codrin.Ciubotariu [this message]
2020-07-23 22:33 ` Florian Fainelli
2020-07-24 7:28 ` Claudiu.Beznea
2020-07-21 17:13 ` [PATCH net-next v2 4/7] ARM: dts: at91: sama5d2: add an mdio sub-node to macb Codrin Ciubotariu
2020-07-23 18:59 ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 5/7] ARM: dts: at91: sama5d3: " Codrin Ciubotariu
2020-07-23 19:00 ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 6/7] ARM: dts: at91: sama5d4: " Codrin Ciubotariu
2020-07-23 19:00 ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 7/7] ARM: dts: at91: sam9x60: " Codrin Ciubotariu
2020-07-23 19:00 ` Florian Fainelli
2020-07-22 10:32 ` [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Claudiu.Beznea
2020-07-22 11:38 ` Codrin.Ciubotariu
2020-07-23 7:51 ` Claudiu.Beznea
2020-07-23 13:18 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba55a2a-487a-dbd5-29e6-5d4231e80167@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).