From: Tomas Bortoli <tomasbortoli@gmail.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: v9fs-developer@lists.sourceforge.net,
Dominique Martinet <dominique.martinet@cea.fr>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 1/3] 9p/net: implement asynchronous rpc
Date: Mon, 17 Dec 2018 23:14:53 +0100 [thread overview]
Message-ID: <1bcb0d99-fc35-3390-e751-5c4ad623e418@gmail.com> (raw)
In-Reply-To: <20181217110111.GB17466@nautica>
On 12/17/18 12:01 PM, Dominique Martinet wrote:
> Tomas Bortoli wrote on Mon, Dec 17, 2018:
>> sorry for the delay, I've been quite busy these days.
>
> No problem.
>
>> The patches looks good to me and should indeed speed up the code a bit.
>> I quickly tested them against Syzkaller tuned for the 9p subsystem and
>> everything seems fine.
>
> Thanks, can I add your Reviewed-by on all three?
>
Sure, FWIW.
>> And by the way, which refcount races?
>
> There's a problem with trans_fd read_work and cancelled callback; I'm
> not so sure about refcount but we can definitely get double list_del
> as we're not checking the status. I think when we incorrectly remove
> from the list we also mismanage the refcount, but honestly need to
> test..
>
Yeah, definitely it needs to check the status. Btw, if a double
list_del happens the kernel should crash.
prev parent reply other threads:[~2018-12-17 22:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 12:41 [PATCH 1/3] 9p/net: implement asynchronous rpc Dominique Martinet
2018-12-11 12:41 ` [PATCH 2/3] 9p/net: make clunk asynchronous Dominique Martinet
2018-12-11 12:41 ` [PATCH 3/3] 9p/net: make flush asynchronous Dominique Martinet
2018-12-17 7:37 ` [PATCH 1/3] 9p/net: implement asynchronous rpc Tomas Bortoli
2018-12-17 7:37 ` Tomas Bortoli
2018-12-17 11:01 ` Dominique Martinet
2018-12-17 22:14 ` Tomas Bortoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bcb0d99-fc35-3390-e751-5c4ad623e418@gmail.com \
--to=tomasbortoli@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=dominique.martinet@cea.fr \
--cc=dvyukov@google.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).