From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yafang Shao <laoar.shao@gmail.com>, Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] tcp: forbid direct reclaim if MSG_DONTWAIT is set in send path
Date: Tue, 9 Oct 2018 18:44:05 -0700 [thread overview]
Message-ID: <1bda85f1-e369-b95e-6f50-a7f795634d03@gmail.com> (raw)
In-Reply-To: <CALOAHbBKabLHkLk4SEU8cRV3JZoTbe9TUiLd9RCp2nOx7Y0fPA@mail.gmail.com>
On 10/09/2018 06:30 PM, Yafang Shao wrote:
> On Tue, Oct 9, 2018 at 11:38 PM Eric Dumazet <edumazet@google.com> wrote:
>>
>> On Tue, Oct 9, 2018 at 7:58 AM Eric Dumazet <edumazet@google.com> wrote:
>>>
>>
>>> We do not add bloat in the kernel if no application is ever going to
>>> use it, especially in the TCP fast path.
>>>
>>
>> BTW, are you willing to change all memory allocations in the kernel as well ?
>>
>> Let say an application is using a system call providing a pathname
>> (open(), stat(), ...), how this system call
>> is going to ask the kernel for no direct reclaim ?
>>
>> Even allocating a socket with socket() or accept() has no ability to
>> avoid direct reclaim.
>>
>> So tcp_sendmsg() is only the tip of the iceberg.
>
> If we can really find a solution that is good enough to hanlde direct
> reclaim in tcp_sendmsg,
> we could also implement it in other syscalls.
> Unexpected latency is hateful.
We have thousands of other places in the kernel, I want to find a generic solution,
not patch all the places one by one.
So come back when you have something more generic, and once applications have a way
to handle gracefully (without calling sendmsg() in infinite loop ...)
to these memory allocation issues.
How is EPOLLOUT going to be generated ?
next prev parent reply other threads:[~2018-10-10 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 12:05 [PATCH v3 net-next] inet: remove redundant backlog setting in listen(2) Yafang Shao
2018-10-09 12:05 ` [PATCH net-next] tcp: forbid direct reclaim if MSG_DONTWAIT is set in send path Yafang Shao
2018-10-09 14:12 ` Eric Dumazet
2018-10-09 14:52 ` Yafang Shao
2018-10-09 14:58 ` Eric Dumazet
2018-10-09 15:38 ` Eric Dumazet
2018-10-10 1:30 ` Yafang Shao
2018-10-10 1:44 ` Eric Dumazet [this message]
2018-10-09 14:00 ` [PATCH v3 net-next] inet: remove redundant backlog setting in listen(2) Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bda85f1-e369-b95e-6f50-a7f795634d03@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).