From: Jens Axboe <axboe@kernel.dk>
To: Arnd Bergmann <arnd@arndb.de>, David Howells <dhowells@redhat.com>
Cc: Jann Horn <jannh@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] watch_queue: make locked_vm accessible
Date: Fri, 6 Sep 2019 09:39:36 -0600 [thread overview]
Message-ID: <1bfa4486-96db-dd83-dc6d-433302f3235f@kernel.dk> (raw)
In-Reply-To: <20190906153249.1864324-1-arnd@arndb.de>
On 9/6/19 9:32 AM, Arnd Bergmann wrote:
> The locked_vm member of struct user_struct is guarded by an #ifdef,
> which breaks building the new watch_queue driver when all the other
> subsystems that need it are disabled:
>
> drivers/misc/watch_queue.c:315:38: error: no member named 'locked_vm' in 'struct user_struct'; did you mean 'locked_shm'?
>
> Add watch_queue to the list.
Should we either:
1) Make it unconditionally available
or
2) Introduce a symbol for this that others can select, like
CONFIG_NEEDS_USER_LOCKED_VM or something like that.
?
--
Jens Axboe
prev parent reply other threads:[~2019-09-06 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:32 [PATCH 1/2] watch_queue: make locked_vm accessible Arnd Bergmann
2019-09-06 15:32 ` [PATCH 2/2] [don't apply] watch_queue: disable sample Arnd Bergmann
2019-09-06 15:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bfa4486-96db-dd83-dc6d-433302f3235f@kernel.dk \
--to=axboe@kernel.dk \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).