From: "David E. Box" <david.e.box@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hdegoede@redhat.com, andriy.shevchenko@linux.intel.com,
srinivas.pandruvada@intel.com, mgross@linux.intel.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon driver
Date: Thu, 03 Feb 2022 21:07:24 -0800 [thread overview]
Message-ID: <1c14e0ce7d2a84f3b7f51abc22f140d6ea69b724.camel@linux.intel.com> (raw)
In-Reply-To: <Yfjz/CRUxeVGKaaQ@kroah.com>
On Tue, 2022-02-01 at 09:49 +0100, Greg KH wrote:
> On Mon, Jan 31, 2022 at 07:04:22PM -0800, David E. Box wrote:
> > +static struct bin_attribute bin_attr_provision_akc;
> > +static struct bin_attribute bin_attr_provision_cap;
>
> <snip>
>
> > +static BIN_ATTR_WO(provision_akc, SDSI_SIZE_WRITE_MSG);
>
> You the structure twice, why?
Will drop. There's no longer a reference to these attributes before they're
defined.
David
>
next prev parent reply other threads:[~2022-02-04 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 3:04 [PATCH 0/3] Intel Software Defined Silicon David E. Box
2022-02-01 3:04 ` [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2022-02-01 8:45 ` Greg KH
2022-02-01 12:32 ` David E. Box
2022-02-01 8:46 ` Greg KH
2022-02-01 8:49 ` Greg KH
2022-02-04 5:07 ` David E. Box [this message]
2022-02-01 3:04 ` [PATCH 2/3] tools arch x86: Add Intel SDSi provisioning tool David E. Box
2022-02-01 3:04 ` [PATCH 3/3] selftests: sdsi: test sysfs setup David E. Box
2022-02-01 8:44 ` [PATCH 0/3] Intel Software Defined Silicon Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c14e0ce7d2a84f3b7f51abc22f140d6ea69b724.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).