linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Oded Gabbay <oded.gabbay@gmail.com>, Mike Rapoport <rppt@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Olof Johansson <olof@lixom.net>,
	ogabbay@habana.ai, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 00/15] Habana Labs kernel driver
Date: Fri, 08 Feb 2019 13:43:09 -0800	[thread overview]
Message-ID: <1c29159a1b55cb6ad278023588861268e22e626c.camel@perches.com> (raw)
In-Reply-To: <CAFCwf10K9Ejqm_=jrtOyXAs4yL-6zs1X79O=dwjg=2jmB3PPYA@mail.gmail.com>

On Fri, 2019-02-08 at 23:33 +0200, Oded Gabbay wrote:
> On Wed, Feb 6, 2019 at 1:52 PM Mike Rapoport <rppt@linux.ibm.com> wrote:
> > On Mon, Feb 04, 2019 at 10:32:39PM +0200, Oded Gabbay wrote:
> > > Hello,
> > > This is v3 of the Habana Labs kernel driver patch-set. It contains minor fixes
> > > according to reviews done on v2. In addition, it is rebased on v5.0-rc5.
[]
> > Nit: git am is unhappy about black lines at EOF, e.g:
> > 
> > Applying: habanalabs: add basic Goya support
> > .git/rebase-apply/patch:29: new blank line at EOF.
> > +
> Yes, but on the other hand, joe perches gave me a comment about
> missing newline at end of Makefile.
> So either diff will complain or git am.

Not really.

The desired modification was the last non-blank line of
the Makefile should have a terminating newline, not that
there was a blank line at EOF.



  reply	other threads:[~2019-02-08 21:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 20:32 [PATCH v3 00/15] Habana Labs kernel driver Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 01/15] habanalabs: add skeleton driver Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 03/15] habanalabs: add basic Goya support Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 04/15] habanalabs: add context and ASID modules Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 05/15] habanalabs: add command buffer module Oded Gabbay
2019-02-08 12:06   ` Greg KH
2019-02-08 19:53     ` Oded Gabbay
2019-02-09  9:09       ` Greg KH
2019-02-04 20:32 ` [PATCH v3 06/15] habanalabs: add basic Goya h/w initialization Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 07/15] habanalabs: add h/w queues module Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 08/15] habanalabs: add event queue and interrupts Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 09/15] habanalabs: add sysfs and hwmon support Oded Gabbay
2019-02-08 12:14   ` Greg KH
2019-02-08 21:18     ` Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 10/15] habanalabs: add device reset support Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 11/15] habanalabs: add command submission module Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 12/15] habanalabs: add virtual memory and MMU modules Oded Gabbay
2019-02-06 15:14   ` Mike Rapoport
2019-02-07 13:15     ` Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 13/15] habanalabs: implement INFO IOCTL Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 14/15] habanalabs: add debugfs support Oded Gabbay
2019-02-06 15:16   ` Mike Rapoport
2019-02-08 12:16   ` Greg KH
2019-02-08 21:24     ` Oded Gabbay
2019-02-04 20:32 ` [PATCH v3 15/15] Update MAINTAINERS and CREDITS with habanalabs info Oded Gabbay
2019-02-06 11:52 ` [PATCH v3 00/15] Habana Labs kernel driver Mike Rapoport
2019-02-08 21:33   ` Oded Gabbay
2019-02-08 21:43     ` Joe Perches [this message]
2019-02-08 21:44       ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c29159a1b55cb6ad278023588861268e22e626c.camel@perches.com \
    --to=joe@perches.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oded.gabbay@gmail.com \
    --cc=ogabbay@habana.ai \
    --cc=olof@lixom.net \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).