From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9225C49EA2 for ; Thu, 17 Jun 2021 08:12:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82BB061351 for ; Thu, 17 Jun 2021 08:12:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbhFQIOo (ORCPT ); Thu, 17 Jun 2021 04:14:44 -0400 Received: from lb3-smtp-cloud8.xs4all.net ([194.109.24.29]:60185 "EHLO lb3-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbhFQIOl (ORCPT ); Thu, 17 Jun 2021 04:14:41 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud8.xs4all.net with ESMTPA id tn8Vl1rpPhqlttn8YlzaY4; Thu, 17 Jun 2021 10:12:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1623917552; bh=xizy2CXykFkxufDLuqw4unYu2vnB4lwNCBc+6uWrkZw=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=KYtX5BO4tMzfvhGPqUaQoK6dOllC3I+5eLmndLy3/GcwfJh5iWKTSyLFDA+XGed2N Fu1655T/WHxrIXpL/MW+rKTU+ACJIuINYSjV1AMp9BuAIRGNf4OrkHnuTOvoXKYd2Q KecyaaOSU69SUk5NFVV0pdt28KFe5TjiCS2Zx98h7Jk8n0o3A2D0/bg3tzkaICZK6u kjRVzUfMwgRAmieL2gofIzBHhAaZljNuddIxMg7ixiqe7aQGnjkAaW11bFUltGV1EY ncDytJLCj5ybSsr6NsvspuhfWcg6VtDZhXuXBK+6CSthacdomsmfIlmhRVjAg1ryNY kGUlfZUS3ak/A== Subject: Re: [PATCH v5 12/15] media: i2c: rdacm20: Embed 'serializer' field To: Jacopo Mondi Cc: Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210616124616.49249-1-jacopo+renesas@jmondi.org> <20210616124616.49249-13-jacopo+renesas@jmondi.org> <1e6e5cd0-82b1-db7a-ec70-ebb8831c11c4@xs4all.nl> <20210617074222.4lbcewsydre4b2nb@uno.localdomain> From: Hans Verkuil Message-ID: <1c460f30-91d3-25a3-78dd-7108bfa24d7c@xs4all.nl> Date: Thu, 17 Jun 2021 10:12:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210617074222.4lbcewsydre4b2nb@uno.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfDa2ORYEmEYVYiISo1WRSeRLLPTvSUtLOZTK3SMsdIuZqq8HAY0X+xWpKmo2BAT4xOgAf6CP1Wmym8+7n/ofeQKBM8vHO1SJur78XcLgdz2/W4YxMU3P eSK8lNUOaaCOuaeFMnD7wyOvJ6CgmuCbgVeikH10xat7w89StLsw/EA3BYbRIGvTmdkPCLKCw09Xii1l58+quHdWbB1N6La9afCEvGzyXlf7DB1DJGBWpx5S OEcodiLa5RLXQydAooMAIfggWJHwni8/GNmg8gfSUgUU/JvU/3PQEL5pbNxv9QqKuQsVTcA0qgyFOeCpDbCZwJ9G6P+c3MkXlvVOGsGyet2shUMmtjOC0G/r tKl+o3h4MxYLFQ3UrrGrqOtWfCyfABkAzdpJltGCGT6T+CwcWrG7Kxn1zNepL8xCp8JQeyKtWaC/PJNtmoIuAF+r1zsiCCdRHaTDSXOnXG/3BZ9kKkVfP6W9 N32Adxbizy4TCKgRuRHBKl783trBt20FitpyWi2rvQY3lK3+iBH4uZi9qXN+OA6Xgp9VFEWq5QAZRplnGaN2JE9gl2uV8YicXeKu+prCJhUgDjpkirfT0sqf z8M= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2021 09:42, Jacopo Mondi wrote: > Hello, > > On Thu, Jun 17, 2021 at 08:18:42AM +0200, Hans Verkuil wrote: >> On 17/06/2021 02:14, Laurent Pinchart wrote: >>> Hi Jacopo, >>> >>> Thank you for the patch. >>> >>> This should be moved before 11/15 to avoid a bisection breakage (or >>> 11/15 should be fixed, and this patch updated accordingly). >> >> Good catch! > > Good catch indeed... Sorry about this I shuffled patches around > multiple times and missed this one > >> >> Jacopo, I dropped the PR I made. It you just want to swap patch 11 and 12, >> then I can do that, if you want more extensive changes, then I need a v6. >> >> Let me know what you want. > > I think swapping 11 and 12 is enough, thanks for handling it. > (BTW there's one additional tag from Kieran to collect which is not in > v5. Would you like a v6 for that ?) Updated the PR and added Kieran's tag. So no need for you to do anything. Regards, Hans > > Thanks > j > >> >> Hans >> >>> >>> On Wed, Jun 16, 2021 at 02:46:13PM +0200, Jacopo Mondi wrote: >>>> There's no reason to allocate dynamically the 'serializer' field in >>>> the driver structure. >>>> >>>> Embed the field and adjust all its users in the driver. >>>> >>>> Signed-off-by: Jacopo Mondi >>>> Reviewed-by: Kieran Bingham >>>> Reviewed-by: Laurent Pinchart >>>> --- >>>> drivers/media/i2c/rdacm20.c | 36 +++++++++++++++--------------------- >>>> 1 file changed, 15 insertions(+), 21 deletions(-) >>>> >>>> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c >>>> index 5e0314a2b1ca..029af8fd7485 100644 >>>> --- a/drivers/media/i2c/rdacm20.c >>>> +++ b/drivers/media/i2c/rdacm20.c >>>> @@ -312,7 +312,7 @@ static const struct ov10635_reg { >>>> >>>> struct rdacm20_device { >>>> struct device *dev; >>>> - struct max9271_device *serializer; >>>> + struct max9271_device serializer; >>>> struct i2c_client *sensor; >>>> struct v4l2_subdev sd; >>>> struct media_pad pad; >>>> @@ -399,7 +399,7 @@ static int rdacm20_s_stream(struct v4l2_subdev *sd, int enable) >>>> { >>>> struct rdacm20_device *dev = sd_to_rdacm20(sd); >>>> >>>> - return max9271_set_serial_link(dev->serializer, enable); >>>> + return max9271_set_serial_link(&dev->serializer, enable); >>>> } >>>> >>>> static int rdacm20_enum_mbus_code(struct v4l2_subdev *sd, >>>> @@ -455,10 +455,10 @@ static int rdacm20_initialize(struct rdacm20_device *dev) >>>> unsigned int retry = 3; >>>> int ret; >>>> >>>> - max9271_wake_up(dev->serializer); >>>> + max9271_wake_up(&dev->serializer); >>>> >>>> /* Serial link disabled during config as it needs a valid pixel clock. */ >>>> - ret = max9271_set_serial_link(dev->serializer, false); >>>> + ret = max9271_set_serial_link(&dev->serializer, false); >>>> if (ret) >>>> return ret; >>>> >>>> @@ -466,35 +466,35 @@ static int rdacm20_initialize(struct rdacm20_device *dev) >>>> * Ensure that we have a good link configuration before attempting to >>>> * identify the device. >>>> */ >>>> - max9271_configure_i2c(dev->serializer, MAX9271_I2CSLVSH_469NS_234NS | >>>> - MAX9271_I2CSLVTO_1024US | >>>> - MAX9271_I2CMSTBT_105KBPS); >>>> + max9271_configure_i2c(&dev->serializer, MAX9271_I2CSLVSH_469NS_234NS | >>>> + MAX9271_I2CSLVTO_1024US | >>>> + MAX9271_I2CMSTBT_105KBPS); >>>> >>>> - max9271_configure_gmsl_link(dev->serializer); >>>> + max9271_configure_gmsl_link(&dev->serializer); >>>> >>>> - ret = max9271_verify_id(dev->serializer); >>>> + ret = max9271_verify_id(&dev->serializer); >>>> if (ret < 0) >>>> return ret; >>>> >>>> - ret = max9271_set_address(dev->serializer, dev->addrs[0]); >>>> + ret = max9271_set_address(&dev->serializer, dev->addrs[0]); >>>> if (ret < 0) >>>> return ret; >>>> - dev->serializer->client->addr = dev->addrs[0]; >>>> + dev->serializer.client->addr = dev->addrs[0]; >>>> >>>> /* >>>> * Reset the sensor by cycling the OV10635 reset signal connected to the >>>> * MAX9271 GPIO1 and verify communication with the OV10635. >>>> */ >>>> - ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT); >>>> + ret = max9271_enable_gpios(&dev->serializer, MAX9271_GPIO1OUT); >>>> if (ret) >>>> return ret; >>>> >>>> - ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); >>>> + ret = max9271_clear_gpios(&dev->serializer, MAX9271_GPIO1OUT); >>>> if (ret) >>>> return ret; >>>> usleep_range(10000, 15000); >>>> >>>> - ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); >>>> + ret = max9271_set_gpios(&dev->serializer, MAX9271_GPIO1OUT); >>>> if (ret) >>>> return ret; >>>> usleep_range(10000, 15000); >>>> @@ -564,13 +564,7 @@ static int rdacm20_probe(struct i2c_client *client) >>>> if (!dev) >>>> return -ENOMEM; >>>> dev->dev = &client->dev; >>>> - >>>> - dev->serializer = devm_kzalloc(&client->dev, sizeof(*dev->serializer), >>>> - GFP_KERNEL); >>>> - if (!dev->serializer) >>>> - return -ENOMEM; >>>> - >>>> - dev->serializer->client = client; >>>> + dev->serializer.client = client; >>>> >>>> ret = of_property_read_u32_array(client->dev.of_node, "reg", >>>> dev->addrs, 2); >>> >>