From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting
Date: Thu, 10 Nov 2016 10:05:36 +0200 [thread overview]
Message-ID: <1c57a006-ddab-f44a-8ec8-24de62a6e02f@linaro.org> (raw)
In-Reply-To: <20161110015251.GC16026@codeaurora.org>
Hi,
On 11/10/2016 03:52 AM, Stephen Boyd wrote:
> On 11/07, Stanimir Varbanov wrote:
>> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
>> index d95c70227c05..7e364691a87c 100644
>> --- a/drivers/firmware/qcom_scm.c
>> +++ b/drivers/firmware/qcom_scm.c
>> @@ -320,6 +320,22 @@ bool qcom_scm_is_available(void)
>> }
>> EXPORT_SYMBOL(qcom_scm_is_available);
>>
>> +int qcom_scm_video_set_state(u32 state, u32 spare)
>> +{
>> + int ret;
>> +
>> + ret = qcom_scm_clk_enable();
>
> Do we need clk control for this? Usually it's only required for
> crypto engine things, and turning on video doesn't sound like it
> uses crypto. I don't think downstream android kernel does this.
Correct, the crypto clk is not needed.
--
regards,
Stan
next prev parent reply other threads:[~2016-11-10 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 17:30 [PATCH v2 0/3] Venus remoteproc driver Stanimir Varbanov
2016-11-07 17:30 ` [PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting Stanimir Varbanov
2016-11-10 1:52 ` Stephen Boyd
2016-11-10 8:05 ` Stanimir Varbanov [this message]
2016-11-07 17:30 ` [PATCH v2 2/3] dt-binding: remoteproc: venus rproc dt binding document Stanimir Varbanov
2016-11-10 1:54 ` Stephen Boyd
2016-11-14 16:58 ` Rob Herring
2016-11-07 17:30 ` [PATCH v2 3/3] remoteproc: qcom: add Venus video core firmware loader driver Stanimir Varbanov
2016-11-14 19:16 ` Stephen Boyd
2016-11-17 9:08 ` Stanimir Varbanov
2016-11-18 17:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c57a006-ddab-f44a-8ec8-24de62a6e02f@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).