From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F8DC1B087 for ; Fri, 4 Dec 2020 16:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64DE522955 for ; Fri, 4 Dec 2020 16:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbgLDQNG (ORCPT ); Fri, 4 Dec 2020 11:13:06 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:43384 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728708AbgLDQNF (ORCPT ); Fri, 4 Dec 2020 11:13:05 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B4G95ps138159; Fri, 4 Dec 2020 16:12:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=87V0vBKZMG5YXDONYo3hdIWeOjNHJMRmA9Y1tYp7IAw=; b=wQ6VPLqq61Gvpsotnsvxxi0MYBhn4OA+gcsxLVgyohkrr7wxrT9x7LifhGS1xEuGk14t AgWXecRxn4iSyQy6DB56rOkpSIOyJfyBmxHt8GSB4BWV6fqb8WiVYWLM92csvN3Tcpiw nTvEAA7vk2uFGEHB5lfkQ/pf8AZOowlfyfI5yIJfdvPJF1rvz4PHTgrU7MN7B7k8+7eN AobBRr31UKywxF/dAF1u20bpPX1eGJ2hhOSv5N4FBJRy2CpXgDqRBe86aEGaqydNwvH7 Lt9610A2s7Y6jFXR0ZAAB3woACSwQqA5ksSJbCvyOOCDcawhoOvI4fIKBRkjDD0whsgB 3A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 353egm3vjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 04 Dec 2020 16:12:11 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B4G9V4n100254; Fri, 4 Dec 2020 16:12:10 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 3540g3v4fx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Dec 2020 16:12:10 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B4GC9VL019559; Fri, 4 Dec 2020 16:12:09 GMT Received: from [10.154.152.223] (/10.154.152.223) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 04 Dec 2020 08:12:09 -0800 Subject: Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() To: Zhang Changzhong , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Maurizio Lombardi Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com> From: Mike Christie Message-ID: <1c6e01d0-9329-862c-6480-fbb91a8910cf@oracle.com> Date: Fri, 4 Dec 2020 10:12:07 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9824 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012040093 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9825 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1011 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012040093 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/4/20 2:43 AM, Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong > --- > drivers/vhost/scsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 6ff8a5096..4ce9f00 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs, > if (!vhost_vq_is_setup(vq)) > continue; > > - if (vhost_scsi_setup_vq_cmds(vq, vq->num)) > + ret = vhost_scsi_setup_vq_cmds(vq, vq->num); > + if (ret) > goto destroy_vq_cmds; > } > > Reviewed-by: Mike Christie