From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/3] perf ftrace: Add ftrace.tracer config option
Date: Fri, 27 Jan 2017 11:57:16 +0900 [thread overview]
Message-ID: <1c77fdfc-3cb0-f26d-d945-ff2231d99eb1@gmail.com> (raw)
In-Reply-To: <20170126185801.GU10340@kernel.org>
Hi, Arnaldo :)
On 01/27/2017 03:58 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 26, 2017 at 06:35:38PM +0900, Taeung Song escreveu:
>> Currently perf ftrace command will select 'function_graph' or 'function'.
>> So add ftrace.tracer config option to select tracer
>>
>> # cat ~/.perfconfig
>> [ftrace]
>> tracer = function
>>
>> # perf ftrace usleep 123456 | head -10
>> <...>-14450 [002] d... 10089.284231: finish_task_switch <-__schedule
>> <...>-14450 [002] .... 10089.284232: finish_wait <-pipe_wait
>> <...>-14450 [002] .... 10089.284232: mutex_lock <-pipe_wait
>> <...>-14450 [002] .... 10089.284232: _cond_resched <-mutex_lock
>> <...>-14450 [002] .... 10089.284233: generic_pipe_buf_confirm <-pipe_read
>>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>> ---
>> tools/perf/builtin-ftrace.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
>> index 414444d..8df5416 100644
>> --- a/tools/perf/builtin-ftrace.c
>> +++ b/tools/perf/builtin-ftrace.c
>> @@ -17,6 +17,7 @@
>> #include "evlist.h"
>> #include "target.h"
>> #include "thread_map.h"
>> +#include "util/config.h"
>>
>>
>> #define DEFAULT_TRACER "function_graph"
>> @@ -198,6 +199,23 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
>> return done ? 0 : -1;
>> }
>>
>> +static int perf_ftrace_config(const char *var, const char *value, void *cb)
>> +{
>> + struct perf_ftrace *ftrace = cb;
>> +
>> + if (!strcmp(var, "ftrace.tracer")) {
>> + if (!strcmp(value, "function_graph"))
>> + ftrace->tracer = DEFAULT_TRACER;
>> + else if (!strcmp(value, "function"))
>> + ftrace->tracer = "function";
>> + else
>> + return -1;
>
> Please warn the user for invalid values and either just say that it is
> ignoring that setting or return -1 to make perf_config() return that,
> then make cmd_ftrace() check the return of perf_config() and bail out if
> you're not ignoring the config value.
>
> I think its better to do a: "pr_err()" in that "return -1" branch and
> make 'perf ftrace' fail, so that the user can fix its config before
> proceeding.
>
I understood it!
I'll modify this patch and resend it. :)
Thanks,
Taeung
next prev parent reply other threads:[~2017-01-27 3:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:35 [PATCH 1/3] perf ftrace: Remove needless code setting default tracer Taeung Song
2017-01-26 9:35 ` [PATCH 2/3] perf ftrace: Add ftrace.tracer config option Taeung Song
2017-01-26 18:58 ` Arnaldo Carvalho de Melo
2017-01-27 2:57 ` Taeung Song [this message]
2017-01-27 3:52 ` Taeung Song
2017-01-26 9:35 ` [PATCH 3/3] perf ftrace: Handle NULL at write_tracing_file() Taeung Song
2017-01-26 18:54 ` [PATCH 1/3] perf ftrace: Remove needless code setting default tracer Arnaldo Carvalho de Melo
2017-02-01 14:37 ` [tip:perf/core] " tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c77fdfc-3cb0-f26d-d945-ff2231d99eb1@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).