From: Vidya Sagar <vidyas@nvidia.com>
To: YueHaibing <yuehaibing@huawei.com>, <lorenzo.pieralisi@arm.com>,
<andrew.murray@arm.com>, <bhelgaas@google.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<treding@nvidia.com>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] PCI: tegra: Add missing include file
Date: Fri, 20 Sep 2019 08:47:25 +0530 [thread overview]
Message-ID: <1c864f34-a2a2-0057-5768-ed992871e927@nvidia.com> (raw)
In-Reply-To: <20190920014807.38288-1-yuehaibing@huawei.com>
On 9/20/2019 7:18 AM, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
> #include <linux/reset.h>
> #include <linux/resource.h>
> #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
> #include "pcie-designware.h"
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>
>
Thanks for pushing this change.
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
next prev parent reply other threads:[~2019-09-20 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 1:48 [PATCH -next] PCI: tegra: Add missing include file YueHaibing
2019-09-20 3:17 ` Vidya Sagar [this message]
2019-09-20 8:17 ` Andrew Murray
2019-09-20 10:39 ` [PATCH v2 " YueHaibing
2019-09-20 10:53 ` Andrew Murray
2019-09-20 15:17 ` Lorenzo Pieralisi
2019-09-20 19:28 ` [PATCH " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c864f34-a2a2-0057-5768-ed992871e927@nvidia.com \
--to=vidyas@nvidia.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).