From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511Ab1BDMYX (ORCPT ); Fri, 4 Feb 2011 07:24:23 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:32973 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429Ab1BDMYT (ORCPT ); Fri, 4 Feb 2011 07:24:19 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; b=bD8Fu68Svg3EGOJAc5Ji/p1FF2Leglw6Ayeb+wBacA2S6L4IwQ3YEl38cKkyv3xIoM 9zACxTkSV8h1dfOsaY/rMZoLgiRHFItsZ6P51LnXWADakYQKUrtNN6B09WJuaS1lueri Rlnj4fmNaJpqr8pcCIeMHyyuA1wY56reQ7YNM= From: Vasiliy Kulikov To: linux-kernel@vger.kernel.org Cc: security@kernel.org, Mike Christie , "James E.J. Bottomley" , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org Subject: [PATCH 19/20] scsi: iscsi: world-writable sysfs priv_sess file Date: Fri, 4 Feb 2011 15:24:14 +0300 Message-Id: <1ca8a99eaadde79e662573d89e4f17a20457fba0.1296818921.git.segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't allow everybody to change iSCSI settings. Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index f905ecb..01543d2 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -1847,7 +1847,7 @@ store_priv_session_##field(struct device *dev, \ #define iscsi_priv_session_rw_attr(field, format) \ iscsi_priv_session_attr_show(field, format) \ iscsi_priv_session_attr_store(field) \ -static ISCSI_CLASS_ATTR(priv_sess, field, S_IRUGO | S_IWUGO, \ +static ISCSI_CLASS_ATTR(priv_sess, field, S_IRUGO | S_IWUSR, \ show_priv_session_##field, \ store_priv_session_##field) iscsi_priv_session_rw_attr(recovery_tmo, "%d"); -- 1.7.0.4