From: Vlastimil Babka <vbabka@suse.cz>
To: Kees Cook <keescook@chromium.org>
Cc: Grzegorz Halat <ghalat@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
ssaner@redhat.com, atomlin@redhat.com, oleksandr@redhat.com,
vbendel@redhat.com, kirill@shutemov.name,
khlebnikov@yandex-team.ru, borntraeger@de.ibm.com,
Andrew Morton <akpm@linux-foundation.org>,
Iurii Zaikin <yzaikin@google.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Qian Cai <cai@lca.pw>
Subject: Re: [PATCH 1/1] mm: sysctl: add panic_on_inconsistent_mm sysctl
Date: Mon, 3 Feb 2020 13:19:29 +0100 [thread overview]
Message-ID: <1cb86d36-7620-be11-7833-0b3bab3c5c1f@suse.cz> (raw)
In-Reply-To: <202001301128.1CBD1BA52@keescook>
On 1/30/20 8:28 PM, Kees Cook wrote:
> On Thu, Jan 30, 2020 at 03:44:50PM +0100, Vlastimil Babka wrote:
>> On 1/29/20 7:08 PM, Grzegorz Halat wrote:
>>> Memory management subsystem performs various checks at runtime,
>>> if an inconsistency is detected then such event is being logged and kernel
>>> continues to run. While debugging such problems it is helpful to collect
>>> memory dump as early as possible. Currently, there is no easy way to panic
>>> kernel when such error is detected.
>>>
>>> It was proposed[1] to panic the kernel if panic_on_oops is set but this
>>> approach was not accepted. One of alternative proposals was introduction of
>>> a new sysctl.
>>>
>>> Add a new sysctl - panic_on_inconsistent_mm. If the sysctl is set then the
>>> kernel will be crashed when an inconsistency is detected by memory
>>> management. This currently means panic when bad page or bad PTE
>>> is detected(this may be extended to other places in MM).
>>
>> I wonder, should enabling the sysctl also effectively convert VM_WARN...
>> to VM_BUG... ?
>
> There is already panic_on_warn sysctl... wouldn't that be sufficient?
True, forgot about it. Thanks.
prev parent reply other threads:[~2020-02-03 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:08 [PATCH 1/1] mm: sysctl: add panic_on_inconsistent_mm sysctl Grzegorz Halat
2020-01-29 18:39 ` Qian Cai
2020-02-03 14:08 ` Christian Borntraeger
2020-02-03 15:06 ` Qian Cai
2020-02-05 22:23 ` Kees Cook
2020-01-29 19:06 ` Qian Cai
2020-01-30 14:44 ` Vlastimil Babka
2020-01-30 19:28 ` Kees Cook
2020-02-03 12:19 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb86d36-7620-be11-7833-0b3bab3c5c1f@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cai@lca.pw \
--cc=corbet@lwn.net \
--cc=ghalat@redhat.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill@shutemov.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=oleksandr@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ssaner@redhat.com \
--cc=vbendel@redhat.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).