From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, bberg@redhat.com, x86@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, ckellner@redhat.com
Subject: Re: [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages
Date: Tue, 15 Oct 2019 07:01:46 -0700 [thread overview]
Message-ID: <1cbbc768361bdf6e9058d9173fa9ef9ba965feba.camel@linux.intel.com> (raw)
In-Reply-To: <20191015084614.GB596@zn.tnic>
On Tue, 2019-10-15 at 10:46 +0200, Borislav Petkov wrote:
> On Mon, Oct 14, 2019 at 03:41:38PM -0700, Srinivas Pandruvada wrote:
> > So some users who had issues in their systems can try with this
> > patch.
> > We can get rid of this, till it becomes real issue.
>
> We don't add command line parameters which we maybe can get rid of
> later.
I am saying the same.
We will not have command line parameter, till this is a problem.
Thanks,
Srinivas
>
> > The temperature is function of load, time and heat dissipation
> > capacity
> > of the system. I have to think more about this to come up with some
> > heuristics where we still warning users about real thermal issues.
> > Since value is not persistent, then next boot again will start from
> > the
> > default.
>
> Yes, and the fact that each machine's temperature is influenced by
> the
> specific *individual* environment and load the machine runs, shows
> that
> you need to adjust this timeout automatically and dynamically.
>
> With the command line parameter you're basically putting the onus on
> the
> user to do that which is just silly. And then she'd need to do it
> during
> runtime too, if the ambient temperature or machine load, etc,
> changes.
>
> The whole thing is crying "dynamic".
>
> For a simple example, see mce_timer_fn() where we switch to polling
> during CMCI storms.
>
next prev parent reply other threads:[~2019-10-15 14:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2c2b65c23be3064504566c5f621c1f37bf7e7326.camel@redhat.com>
2019-10-14 21:21 ` [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages Srinivas Pandruvada
2019-10-14 21:21 ` [PATCH 2/2] x86, mce: Add additional kernel boot parameter Srinivas Pandruvada
2019-10-14 21:36 ` [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages Borislav Petkov
2019-10-14 22:27 ` Luck, Tony
2019-10-15 8:36 ` Borislav Petkov
2019-10-15 8:52 ` Peter Zijlstra
2019-10-15 13:43 ` Srinivas Pandruvada
2019-10-14 22:41 ` Srinivas Pandruvada
2019-10-15 8:46 ` Borislav Petkov
2019-10-15 14:01 ` Srinivas Pandruvada [this message]
2019-10-15 8:48 ` Peter Zijlstra
2019-10-15 13:31 ` Srinivas Pandruvada
2019-10-16 8:14 ` Peter Zijlstra
2019-10-16 14:00 ` Borislav Petkov
2019-10-17 21:31 ` Luck, Tony
2019-10-17 21:44 ` Borislav Petkov
2019-10-17 23:53 ` Luck, Tony
2019-10-18 6:46 ` Borislav Petkov
2019-10-18 7:17 ` Peter Zijlstra
2019-10-18 12:26 ` Srinivas Pandruvada
2019-10-18 13:23 ` Borislav Petkov
2019-10-18 15:55 ` Srinivas Pandruvada
2019-10-18 19:40 ` Borislav Petkov
2019-10-18 18:02 ` Luck, Tony
2019-10-18 19:45 ` Borislav Petkov
2019-10-18 20:38 ` Luck, Tony
2019-10-19 8:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cbbc768361bdf6e9058d9173fa9ef9ba965feba.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=bberg@redhat.com \
--cc=bp@alien8.de \
--cc=ckellner@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).