From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3B3C4338F for ; Fri, 30 Jul 2021 06:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A1FF60F4B for ; Fri, 30 Jul 2021 06:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237270AbhG3GJ2 (ORCPT ); Fri, 30 Jul 2021 02:09:28 -0400 Received: from mga05.intel.com ([192.55.52.43]:21194 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233890AbhG3GJ1 (ORCPT ); Fri, 30 Jul 2021 02:09:27 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="298623238" X-IronPort-AV: E=Sophos;i="5.84,281,1620716400"; d="scan'208";a="298623238" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 23:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,281,1620716400"; d="scan'208";a="465344760" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga008.jf.intel.com with ESMTP; 29 Jul 2021 23:09:20 -0700 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH v2 04/24] iommu/vt-d: Drop IOVA cookie management To: Robin Murphy , joro@8bytes.org, will@kernel.org References: <6630ae3191be428135a7269c15b17d03c90573c1.1627468309.git.robin.murphy@arm.com> From: Lu Baolu Message-ID: <1cc3a65c-15b6-f971-3ea3-668ebb0b20f5@linux.intel.com> Date: Fri, 30 Jul 2021 14:07:02 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <6630ae3191be428135a7269c15b17d03c90573c1.1627468309.git.robin.murphy@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/21 11:58 PM, Robin Murphy wrote: > The core code bakes its own cookies now. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/intel/iommu.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index c12cc955389a..7e168634c433 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -1979,10 +1979,6 @@ static void domain_exit(struct dmar_domain *domain) > /* Remove associated devices and clear attached or cached domains */ > domain_remove_dev_info(domain); > > - /* destroy iovas */ > - if (domain->domain.type == IOMMU_DOMAIN_DMA) > - iommu_put_dma_cookie(&domain->domain); > - > if (domain->pgd) { > struct page *freelist; > > @@ -4544,10 +4540,6 @@ static struct iommu_domain *intel_iommu_domain_alloc(unsigned type) > return NULL; > } > > - if (type == IOMMU_DOMAIN_DMA && > - iommu_get_dma_cookie(&dmar_domain->domain)) > - return NULL; > - > domain = &dmar_domain->domain; > domain->geometry.aperture_start = 0; > domain->geometry.aperture_end = > Reviewed-by: Lu Baolu Best regards, baolu