From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752531AbdFZP4i (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Jun 2017 11:56:38 -0400
Received: from fllnx209.ext.ti.com ([198.47.19.16]:40428 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752363AbdFZPzs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Jun 2017 11:55:48 -0400
Subject: Re: [PATCH v3 2/3] remoteproc/keystone: Add a remoteproc driver for
 Keystone 2 DSPs
To: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: Ohad Ben-Cohen <ohad@wizery.com>, Rob Herring <robh+dt@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        <linux-remoteproc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, "Andrew F. Davis" <afd@ti.com>,
        Sam Nelson <sam.nelson@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>
References: <20170613234513.7624-1-s-anna@ti.com>
 <20170613234513.7624-3-s-anna@ti.com> <20170625201545.GA26155@builder>
From: Suman Anna <s-anna@ti.com>
Message-ID: <1ccd9273-0fde-4241-6d99-1d03be2f5b57@ti.com>
Date: Mon, 26 Jun 2017 10:54:16 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170625201545.GA26155@builder>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [128.247.58.153]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bjorn,

On 06/25/2017 03:15 PM, Bjorn Andersson wrote:
> On Tue 13 Jun 16:45 PDT 2017, Suman Anna wrote:
> 
>> +static int keystone_rproc_start(struct rproc *rproc)
>> +{
>> +	struct keystone_rproc *ksproc = rproc->priv;
>> +	int ret;
>> +
>> +	INIT_WORK(&ksproc->workqueue, handle_event);
>> +
>> +	ret = request_irq(ksproc->irq_ring, keystone_rproc_vring_interrupt, 0,
>> +			  dev_name(ksproc->dev), ksproc);
>> +	if (ret) {
>> +		dev_err(ksproc->dev, "failed to enable vring interrupt, ret = %d\n",
>> +			ret);
>> +		goto out;
>> +	}
>> +
>> +	ret = request_irq(ksproc->irq_fault, keystone_rproc_exception_interrupt,
>> +			  0, dev_name(ksproc->dev), ksproc);
>> +	if (ret) {
>> +		dev_err(ksproc->dev, "failed to enable exception interrupt, ret = %d\n",
>> +			ret);
>> +		goto free_vring_irq;
>> +	}
> 
> I do prefer that your request any resources during probe() and
> potentially enable/disable them here. If below concern about using a
> GPIO driver is cleared already I'll take it as is though.
> 
> [..]
>> +static void keystone_rproc_kick(struct rproc *rproc, int vqid)
>> +{
>> +	struct keystone_rproc *ksproc = rproc->priv;
>> +
>> +	if (WARN_ON(ksproc->kick_gpio < 0))
>> +		return;
>> +
>> +	gpio_set_value(ksproc->kick_gpio, 1);
>> +}
>> +
> 
> This doesn't sound like a gpio-controller and the GPIO maintainer did
> reject an attempt by me to use the GPIO framework to abstract a similar
> thing. Do you already have this driver upstream or have you clarified
> with the maintainer that the GPIO framework is an acceptable abstraction
> for this?

Yeah, this has been upstream since quite some time. See commit
2134cb997f2f ("gpio: syscon: reuse for keystone 2 socs").

regards
Suman

> 
> It looks equivalent to the "APCS IPC" register found in Qualcomm
> platforms, previously implemented through a syscon but in v4.13 being
> pushed to being a mailbox driver.
> 
> 
> Apart from this I think the series looks good.
> 
> Regards,
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>