From: Robin Murphy <robin.murphy@arm.com>
To: Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com,
linux-arm-kernel@lists.infradead.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports
Date: Tue, 21 Jan 2020 14:56:58 +0000 [thread overview]
Message-ID: <1cd15d49-3c4f-6da2-4d4f-0414dd6d6adc@arm.com> (raw)
In-Reply-To: <20200121134510.3893487-1-heiko@sntech.de>
On 21/01/2020 1:45 pm, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 9b1c92132007..37e014444214 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -421,19 +421,24 @@ lvds: lvds {
> rockchip,output = "lvds";
> status = "disabled";
FWIW, the main node's "#{address,size}-cells" properties above here
should now be unnecessary too.
Robin.
>
> - port@0 {
> - reg = <0>;
> + ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - lvds_vopb_in: endpoint@0 {
> + port@0 {
> reg = <0>;
> - remote-endpoint = <&vopb_out_lvds>;
> - };
> -
> - lvds_vopl_in: endpoint@1 {
> - reg = <1>;
> - remote-endpoint = <&vopl_out_lvds>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lvds_vopb_in: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vopb_out_lvds>;
> + };
> +
> + lvds_vopl_in: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&vopl_out_lvds>;
> + };
> };
> };
> };
>
next prev parent reply other threads:[~2020-01-21 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:45 [PATCH] arm64: dts: rockchip: fix px30 lvds ports Heiko Stuebner
2020-01-21 13:59 ` Miquel Raynal
2020-01-21 14:56 ` Robin Murphy [this message]
2020-01-21 22:20 [PATCH v2] " Heiko Stuebner
2020-01-21 22:20 ` [PATCH] " Heiko Stuebner
2020-01-21 22:23 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd15d49-3c4f-6da2-4d4f-0414dd6d6adc@arm.com \
--to=robin.murphy@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).