From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbdCWIEx (ORCPT ); Thu, 23 Mar 2017 04:04:53 -0400 Received: from smtpfb2-g21.free.fr ([212.27.42.10]:39567 "EHLO smtpfb2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbdCWIEu (ORCPT ); Thu, 23 Mar 2017 04:04:50 -0400 Subject: Re: [PATCH 0/3] staging: media: Replace a bit shift. To: Arushi Singhal , outreachy-kernel@googlegroups.com References: <20170322042609.23525-1-arushisinghal19971997@gmail.com> Cc: linux-media@vger.kernel.org, gregkh@linuxfoundation.org, mchehab@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Chris Moore Message-ID: <1cdeae57-73b1-c62c-da9a-b9e75d2f2ab1@free.fr> Date: Thu, 23 Mar 2017 07:46:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170322042609.23525-1-arushisinghal19971997@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le 22/03/2017 à 05:26, Arushi Singhal a écrit : > Replace a bit shift by a use of BIT in media driver. > > Arushi Singhal (3): > staging: media: Replace a bit shift by a use of BIT. > staging: media: davinci_vpfe: Replace a bit shift by a use of BIT. > staging: media: omap4iss: Replace a bit shift by a use of BIT. > > .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 +++++----- > .../atomisp/pci/atomisp2/atomisp_compat_css20.c | 6 ++--- > .../media/atomisp/pci/atomisp2/atomisp_drvfs.c | 6 ++--- > .../media/atomisp/pci/atomisp2/atomisp_v4l2.c | 18 +++++++-------- > .../media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_isif.c | 26 +++++++++++----------- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 ++--- > drivers/staging/media/omap4iss/iss_csi2.c | 2 +- > drivers/staging/media/omap4iss/iss_ipipe.c | 2 +- > drivers/staging/media/omap4iss/iss_ipipeif.c | 2 +- > drivers/staging/media/omap4iss/iss_resizer.c | 2 +- > 13 files changed, 44 insertions(+), 44 deletions(-) > Most of these replacements add redundant parentheses around the BIT macro. IMHO this makes the code less readable. So I suggest (BIT(c)) -> BIT(c). Cheers, Chris