From: Michael Walle <michael@walle.cc>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: wm8904: configure sysclk/FLL automatically
Date: Fri, 08 Nov 2019 18:14:15 +0100 [thread overview]
Message-ID: <1ce127111686a80fe1461d49bac50f86@walle.cc> (raw)
In-Reply-To: <20191108160704.GA10439@ediswmail.ad.cirrus.com>
Am 2019-11-08 17:07, schrieb Charles Keepax:
> On Fri, Nov 08, 2019 at 12:15:48AM +0100, Michael Walle wrote:
>> This adds a new mode WM8904_CLK_AUTO which automatically enables the
>> FLL
>> if a frequency different than the MCLK is set.
>>
>> These additions make the codec work with the simple-card driver in
>> general and especially in systems where the MCLK doesn't match the
>> requested clock.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> +static int wm8904_set_sysclk(struct snd_soc_dai *dai, int clk_id,
>> + unsigned int freq, int dir)
>> +{
>> + struct snd_soc_component *component = dai->component;
>> + struct wm8904_priv *priv = snd_soc_component_get_drvdata(component);
>> + unsigned long mclk_freq;
>> + int ret;
>> +
>> + switch (clk_id) {
>> + case WM8904_CLK_AUTO:
>> + mclk_freq = clk_get_rate(priv->mclk);
>> + /* enable FLL if a different sysclk is desired */
>> + if (mclk_freq != freq) {
>> + priv->sysclk_src = WM8904_CLK_FLL;
>> + ret = wm8904_set_fll(dai, WM8904_FLL_MCLK,
>> + WM8904_FLL_MCLK,
>> + clk_get_rate(priv->mclk), freq);
>
> minor nit, might as well use mclk_freq rather than calling
> clk_get_rate again, other than that though I think this looks
> good.
whoops, I was too tired then. That was the whole intention of using the
mclk_freq variable.. so yes, I'll fix that.
-michael
prev parent reply other threads:[~2019-11-08 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 23:15 [PATCH] ASoC: wm8904: configure sysclk/FLL automatically Michael Walle
2019-11-08 16:07 ` Charles Keepax
2019-11-08 17:14 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce127111686a80fe1461d49bac50f86@walle.cc \
--to=michael@walle.cc \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).