From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 0/3] perf: Support a new coresum event qualifier
Date: Sat, 16 Mar 2019 07:07:17 +0800 [thread overview]
Message-ID: <1d1d6263-9842-7d44-8edb-dcfbb5a2e6cc@linux.intel.com> (raw)
In-Reply-To: <20190315133443.GA5200@krava>
On 3/15/2019 9:34 PM, Jiri Olsa wrote:
> On Sat, Mar 16, 2019 at 12:04:13AM +0800, Jin Yao wrote:
>> The coresum event qualifier which sums up the event counts for both
>> hardware threads in a core. For example,
>>
>> perf stat -e cpu/event=0,umask=0x3,coresum=1/,cpu/event=0,umask=0x3/
>>
>> In this example, we count the event 'ref-cycles' per-core and per-CPU in
>> one perf stat command-line.
>>
>> We can already support per-core counting with --per-core, but it's
>> often useful to do this together with other metrics that are collected
>> per CPU (per hardware thread). So this patch series supports this
>> per-core counting on a event level.
>
> seems useful, but perhaps we should follow the --per-core option
> we already have and call it 'per-core' instead of coresum
>
> jirka
>
Yes, the coresum's behavior is similar as --per-core option, just
supports at the event level. I'm OK with calling it 'per-core'.
For example,
perf stat -e cpu/event=0,umask=0x3,per-core=1/
Thanks
Jin Yao
>>
>> Jin Yao (3):
>> perf: Add a coresum event qualifier
>> perf stat: Support coresum event qualifier
>> perf test: Add a simple test for term coresum
>>
>> tools/perf/Documentation/perf-stat.txt | 4 ++
>> tools/perf/builtin-stat.c | 21 +++++++
>> tools/perf/tests/parse-events.c | 10 ++-
>> tools/perf/util/evsel.c | 2 +
>> tools/perf/util/evsel.h | 3 +
>> tools/perf/util/parse-events.c | 27 +++++++++
>> tools/perf/util/parse-events.h | 1 +
>> tools/perf/util/parse-events.l | 1 +
>> tools/perf/util/stat-display.c | 108 ++++++++++++++++++++++++---------
>> tools/perf/util/stat.c | 8 ++-
>> 10 files changed, 151 insertions(+), 34 deletions(-)
>>
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2019-03-15 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 16:04 [PATCH v1 0/3] perf: Support a new coresum event qualifier Jin Yao
2019-03-15 13:34 ` Jiri Olsa
2019-03-15 23:07 ` Jin, Yao [this message]
2019-03-15 23:26 ` Andi Kleen
2019-03-15 23:31 ` Jin, Yao
2019-03-15 16:04 ` [PATCH v1 1/3] perf: Add a " Jin Yao
2019-03-15 16:04 ` [PATCH v1 2/3] perf stat: Support " Jin Yao
2019-03-15 13:34 ` Jiri Olsa
2019-03-15 23:08 ` Jin, Yao
2019-03-15 16:04 ` [PATCH v1 3/3] perf test: Add a simple test for term coresum Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1d6263-9842-7d44-8edb-dcfbb5a2e6cc@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).