From: Luben Tuikov <luben.tuikov@amd.com>
To: Takashi Iwai <tiwai@suse.de>, dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint
Date: Fri, 23 Oct 2020 19:16:38 -0400 [thread overview]
Message-ID: <1d3e22ef-a301-f557-79ca-33d6520bb64e@amd.com> (raw)
In-Reply-To: <20201023074656.11855-1-tiwai@suse.de>
On 2020-10-23 03:46, Takashi Iwai wrote:
> Hi,
>
> the amdgpu driver's ASSERT_CRITICAL() macro calls the
> kgdb_breakpoing() even if no debug option is set, and this leads to a
> kernel panic on distro kernels. The first two patches are the
> oneliner fixes for those, while the last one is the cleanup of those
> debug macros.
This looks like good work and solid. Hopefully it gets picked up.
Regards,
Luben
>
>
> Takashi
>
> ===
>
> Takashi Iwai (3):
> drm/amd/display: Fix kernel panic by dal_gpio_open() error
> drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
> drm/amd/display: Clean up debug macros
>
> drivers/gpu/drm/amd/display/Kconfig | 1 +
> drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 +--
> drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++++++++----------------
> 3 files changed, 15 insertions(+), 23 deletions(-)
>
next prev parent reply other threads:[~2020-10-23 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 7:46 [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint Takashi Iwai
2020-10-23 7:46 ` [PATCH 1/3] drm/amd/display: Fix kernel panic by dal_gpio_open() error Takashi Iwai
2020-10-23 7:46 ` [PATCH 2/3] drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally Takashi Iwai
2020-10-23 7:46 ` [PATCH 3/3] drm/amd/display: Clean up debug macros Takashi Iwai
2020-10-23 23:16 ` Luben Tuikov [this message]
2020-10-26 19:34 ` [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint Alex Deucher
2020-10-26 20:22 ` Kazlauskas, Nicholas
2020-10-26 20:33 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3e22ef-a301-f557-79ca-33d6520bb64e@amd.com \
--to=luben.tuikov@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).