From: Christophe ROULLIER <christophe.roullier@st.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Peppe CAVALLARO <peppe.cavallaro@st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization
Date: Mon, 23 Sep 2019 07:46:11 +0000 [thread overview]
Message-ID: <1d5dfc73-73e1-fe47-d1f6-9c24f9e5e532@st.com> (raw)
In-Reply-To: <20190922151257.51173d89@cakuba.netronome.com>
Hi Jakub, all,
It is not urgent, no problem to wait next merge window (release 5.5)
For patch 1 and 3, it is improvement/cleanup because now syscfg clock is
not mandatory (I put code backward compatible).
Regards,
Christophe
On 9/23/19 12:12 AM, Jakub Kicinski wrote:
> On Fri, 20 Sep 2019 07:38:12 +0200, Christophe Roullier wrote:
>> Some improvements (manage syscfg as optional clock, update slew rate of
>> ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode)
>> Fix warning build message when W=1
> There seems to be some new features/cleanups (or improvements as
> you say) here. Could you explain the negative impact not applying
> these changes will have? Patches 1 and 3 in particular.
>
> net-next is now closed [1], and will reopen some time after the merge
> window is over. For now we are only expecting fixes for the net tree.
>
> Could you (a) provide stronger motivation these changes are fixes; or
> (b) separate the fixes from improvements?
>
> Thank you!
>
> [1] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
next prev parent reply other threads:[~2019-09-23 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 5:38 [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Christophe Roullier
2019-09-20 5:38 ` [PATCH 1/5] net: ethernet: stmmac: Add support for syscfg clock Christophe Roullier
2019-10-03 10:13 ` Alexandre Torgue
2019-09-20 5:38 ` [PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build Christophe Roullier
2019-10-03 10:14 ` Alexandre Torgue
2019-09-20 5:38 ` [PATCH 3/5] ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet Christophe Roullier
2019-09-20 5:38 ` [PATCH 4/5] ARM: dts: stm32: adjust slew rate for Ethernet Christophe Roullier
2019-09-20 5:38 ` [PATCH 5/5] ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power mode on stm32mp157c Christophe Roullier
2019-09-22 22:12 ` [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Jakub Kicinski
2019-09-23 7:46 ` Christophe ROULLIER [this message]
2019-10-25 9:17 ` Christophe ROULLIER
2019-10-03 10:16 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5dfc73-73e1-fe47-d1f6-9c24f9e5e532@st.com \
--to=christophe.roullier@st.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).