From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
kvm@vger.kernel.org, rafael@kernel.org,
David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>,
Stuart Yoder <stuyoder@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v6 02/11] driver core: Add dma_cleanup callback in bus_type
Date: Mon, 21 Feb 2022 20:43:33 +0000 [thread overview]
Message-ID: <1d8004d3-1887-4fc7-08d2-0e2ee6b5fdcb@arm.com> (raw)
In-Reply-To: <YhCdEmC2lYStmUSL@infradead.org>
On 2022-02-19 07:32, Christoph Hellwig wrote:
> So we are back to the callback madness instead of the nice and simple
> flag? Sigh.
TBH, I *think* this part could be a fair bit simpler. It looks like this
whole callback mess is effectively just to decrement group->owner_cnt,
but since we should only care about ownership at probe, hotplug, and
other places well outside critical fast-paths, I'm not sure we really
need to keep track of that anyway - it can always be recalculated by
walking the group->devices list, and some of the relevant places have to
do that anyway. It should be pretty straightforward for
iommu_bus_notifier to clear group->owner automatically upon an unbind of
the matching driver when it's no longer bound to any other devices in
the group either. And if we still want to entertain the notion of VFIO
being able to release ownership without unbinding (I'm not entirely
convinced that's a realistically necessary use-case) then it should be
up to VFIO to decide when it's finally finished with the whole group,
rather than pretending we can keep track of nested ownership claims from
inside the API.
Furthermore, If Greg was willing to compromise just far enough to let us
put driver_managed_dma in the 3-byte hole in the generic struct
device_driver, we wouldn't have to have quite so much boilerplate
repeated across the various bus implementations (I'm not suggesting to
move any actual calls back into the driver core, just the storage of
flag itself). FWIW I have some ideas for re-converging .dma_configure in
future which I think should probably be able to subsume this into a
completely generic common path, given a common flag.
Robin.
next prev parent reply other threads:[~2022-02-21 20:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 0:55 [PATCH v6 00/11] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu
2022-02-18 0:55 ` [PATCH v6 01/11] iommu: Add dma ownership management interfaces Lu Baolu
2022-02-19 7:31 ` Christoph Hellwig
2022-02-21 4:02 ` Lu Baolu
2022-02-23 18:00 ` Robin Murphy
2022-02-23 18:02 ` Jason Gunthorpe
2022-02-23 18:20 ` Robin Murphy
2022-02-23 18:32 ` Jason Gunthorpe
2022-02-24 5:16 ` Lu Baolu
2022-02-24 5:29 ` Lu Baolu
2022-02-24 8:58 ` Robin Murphy
2022-02-24 5:21 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 02/11] driver core: Add dma_cleanup callback in bus_type Lu Baolu
2022-02-19 7:32 ` Christoph Hellwig
2022-02-21 20:43 ` Robin Murphy [this message]
2022-02-21 23:48 ` Jason Gunthorpe
2022-02-22 4:48 ` Lu Baolu
2022-02-22 10:58 ` Robin Murphy
2022-02-22 15:16 ` Jason Gunthorpe
2022-02-22 21:18 ` Robin Murphy
2022-02-22 23:53 ` Jason Gunthorpe
2022-02-23 5:01 ` Lu Baolu
2022-02-23 13:04 ` Robin Murphy
2022-02-23 13:46 ` Jason Gunthorpe
2022-02-23 14:06 ` Greg Kroah-Hartman
2022-02-23 14:09 ` Jason Gunthorpe
2022-02-23 14:30 ` Jason Gunthorpe
2022-02-23 16:03 ` Greg Kroah-Hartman
2022-02-23 17:05 ` Robin Murphy
2022-02-23 17:47 ` Greg Kroah-Hartman
2022-02-18 0:55 ` [PATCH v6 03/11] amba: Stop sharing platform_dma_configure() Lu Baolu
2022-02-18 0:55 ` [PATCH v6 04/11] bus: platform,amba,fsl-mc,PCI: Add device DMA ownership management Lu Baolu
2022-02-18 7:55 ` Greg Kroah-Hartman
2022-02-18 0:55 ` [PATCH v6 05/11] PCI: pci_stub: Set driver_managed_dma Lu Baolu
2022-02-18 0:55 ` [PATCH v6 06/11] PCI: portdrv: " Lu Baolu
2022-02-18 0:55 ` [PATCH v6 07/11] vfio: Set DMA ownership for VFIO devices Lu Baolu
2022-02-18 0:55 ` [PATCH v6 08/11] vfio: Remove use of vfio_group_viable() Lu Baolu
2022-02-18 0:55 ` [PATCH v6 09/11] vfio: Delete the unbound_list Lu Baolu
2022-02-18 0:55 ` [PATCH v6 10/11] vfio: Remove iommu group notifier Lu Baolu
2022-02-23 21:53 ` Alex Williamson
2022-02-24 2:49 ` Lu Baolu
2022-02-18 0:55 ` [PATCH v6 11/11] iommu: Remove iommu group changes notifier Lu Baolu
2022-02-18 15:51 ` [PATCH v6 00/11] Fix BUG_ON in vfio_iommu_group_notifier() Jason Gunthorpe
2022-02-21 3:38 ` Lu Baolu
2022-02-28 0:58 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d8004d3-1887-4fc7-08d2-0e2ee6b5fdcb@arm.com \
--to=robin.murphy@arm.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stuyoder@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).