From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbdKHOOJ (ORCPT ); Wed, 8 Nov 2017 09:14:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48360 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdKHOOI (ORCPT ); Wed, 8 Nov 2017 09:14:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 13CDE5D9E4 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eric.auger@redhat.com Subject: Re: [PATCH v5 12/26] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171027142855.21584-1-marc.zyngier@arm.com> <20171027142855.21584-13-marc.zyngier@arm.com> <052a6676-c15a-6d91-da1e-660312c29f1b@redhat.com> Cc: Christoffer Dall , Shanker Donthineni , Mark Rutland , Shameerali Kolothum Thodi , Andre Przywara , Christoffer Dall From: Auger Eric Message-ID: <1da6c685-28f0-ae5c-b47c-738730d2faa9@redhat.com> Date: Wed, 8 Nov 2017 15:14:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 08 Nov 2017 14:14:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/11/2017 12:52, Marc Zyngier wrote: > On 07/11/17 20:28, Auger Eric wrote: >> Hi Marc, >> >> On 27/10/2017 16:28, Marc Zyngier wrote: >>> When freeing an LPI (on a DISCARD command, for example), we need >>> to unmap the VLPI down to the physical ITS level. >>> >>> Acked-by: Christoffer Dall >>> Signed-off-by: Marc Zyngier >>> --- >>> virt/kvm/arm/vgic/vgic-its.c | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c >>> index b2a678d131d0..c9b1c0967426 100644 >>> --- a/virt/kvm/arm/vgic/vgic-its.c >>> +++ b/virt/kvm/arm/vgic/vgic-its.c >>> @@ -628,8 +628,12 @@ static void its_free_ite(struct kvm *kvm, struct its_ite *ite) >>> list_del(&ite->ite_list); >>> >>> /* This put matches the get in vgic_add_lpi. */ >>> - if (ite->irq) >>> + if (ite->irq) { >>> + if (ite->irq->hw) >>> + WARN_ON(its_unmap_vlpi(ite->irq->host_irq)); >>> + >>> vgic_put_irq(kvm, ite->irq); >> You could have put the its_unmap_vlpi() directly in vgic_put_irq which >> is meant to decr the ref/release the LPI irq. > > Do you see this as an issue? not really. I just thought it would be nicer in vgic_put_irq but that's a detail. Thanks Eric > > I'm trying hard to keep the GICv4 changes local to the ITS code, and not > spread it everywhere in the vgic, but I'll happily change it if you spot > something that seems wrong. > > Thanks, > > M. >