From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Rob Herring <robh@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
kvmarm@lists.linux.dev, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 14/14] arm64/sysreg: Convert TRBIDR_EL1 register to automatic generation
Date: Tue, 13 Jun 2023 09:56:31 +0530 [thread overview]
Message-ID: <1dca7ec8-a0d1-3038-7e9f-0d2934dc2e37@arm.com> (raw)
In-Reply-To: <4de1ec32-f07b-4eca-99e2-f71a08f5cd5b@sirena.org.uk>
On 6/2/23 17:42, Mark Brown wrote:
> On Fri, Jun 02, 2023 at 11:55:52AM +0530, Anshuman Khandual wrote:
>> This converts TRBIDR_EL1 register to automatic generation without
>> causing any functional change.
>
>> +Sysreg TRBIDR_EL1 3 0 9 11 7
>> +Res0 63:12
>> +Field 11:8 EA
>
> EA is another field which looks like it should be an enum, as with the
> others this shouldn't be a blocker and could be done incrementally.
Will fold the following changes in this patch.
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2267,7 +2267,11 @@ EndSysreg
Sysreg TRBIDR_EL1 3 0 9 11 7
Res0 63:12
-Field 11:8 EA
+Enum 11:8 EA
+ 0b0000 NON_DESC
+ 0b0001 IGNORE
+ 0b0010 SERROR
+EndEnum
Res0 7:6
Field 5 F
Field 4 P
>
>> +Res0 7:6
>> +Field 5 F
>> +Field 4 P
>> +Field 3:0 Align
>
> Align arguably too though really it's just encoding the relevant power
> of 2 with the enum coming from the fact that it's limited to at most 2KB
> alignment so a Field may well make more sense.
Can fold the following changes in this patch (if required) unless the Field
looks better than Enum.
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2275,5 +2275,18 @@ EndEnum
Res0 7:6
Field 5 F
Field 4 P
-Field 3:0 Align
+Enum 3:0 Align
+ 0b0000 BYTE
+ 0b0001 HALF_WORD
+ 0b0010 WORD
+ 0b0011 DOUBLE_WORD
+ 0b0100 16_BYTES
+ 0b0101 32_BYTES
+ 0b0110 64_BYTES
+ 0b0111 128_BYTES
+ 0b1000 156_BYTES
+ 0b1001 512_BYTES
+ 0b1010 1_KB
+ 0b1011 2_KB
+EndEnum
EndSysreg
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
next prev parent reply other threads:[~2023-06-13 4:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 6:25 [PATCH V2 00/14] arm64/sysreg: Convert TRBE registers to automatic generation Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 01/14] arm64/sysreg: Rename TRBLIMITR_EL1 fields per auto-gen tools format Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 02/14] arm64/sysreg: Rename TRBPTR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 03/14] arm64/sysreg: Rename TRBBASER_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 04/14] arm64/sysreg: Rename TRBSR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 05/14] arm64/sysreg: Rename TRBMAR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 06/14] arm64/sysreg: Rename TRBTRG_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 07/14] arm64/sysreg: Rename TRBIDR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 08/14] arm64/sysreg: Convert TRBLIMITR_EL1 register to automatic generation Anshuman Khandual
2023-06-02 11:57 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 09/14] arm64/sysreg: Convert TRBPTR_EL1 " Anshuman Khandual
2023-06-02 11:58 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 10/14] arm64/sysreg: Convert TRBBASER_EL1 " Anshuman Khandual
2023-06-02 11:59 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 11/14] arm64/sysreg: Convert TRBSR_EL1 " Anshuman Khandual
2023-06-02 12:00 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 12/14] arm64/sysreg: Convert TRBMAR_EL1 " Anshuman Khandual
2023-06-02 12:05 ` Mark Brown
2023-06-13 4:01 ` Anshuman Khandual
2023-06-13 11:03 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 13/14] arm64/sysreg: Convert TRBTRG_EL1 " Anshuman Khandual
2023-06-02 12:06 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 14/14] arm64/sysreg: Convert TRBIDR_EL1 " Anshuman Khandual
2023-06-02 12:12 ` Mark Brown
2023-06-13 4:26 ` Anshuman Khandual [this message]
2023-06-13 11:02 ` Mark Brown
2023-06-08 17:39 ` [PATCH V2 00/14] arm64/sysreg: Convert TRBE registers " Catalin Marinas
2023-06-13 4:27 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dca7ec8-a0d1-3038-7e9f-0d2934dc2e37@arm.com \
--to=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).